From owner-freebsd-hackers@FreeBSD.ORG Fri Nov 5 23:28:41 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 35F98106564A for ; Fri, 5 Nov 2010 23:28:40 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id D499C8FC12 for ; Fri, 5 Nov 2010 23:28:39 +0000 (UTC) Received: by qwg8 with SMTP id 8so2949537qwg.13 for ; Fri, 05 Nov 2010 16:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=IB1eizm5hWB2Sm6J/dBpsu5sNiyGI6IuRqxV/IsQVa0=; b=OShABctybFk6eQgW1JlwQtF2gm47A/N+DcA+i6SJpur6heAl6bj/zaX3DcYhmGMDru XNxGqGw3TPsqrIyNMLi+oGYutFBV5FyDmbzAtekfVVdVS7XLDYazveexx7Ow1j0vwLiN 2VGsC9+MyfGbbopMPmzZk2Y3FKmhYEMDF7F7s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=JAILaRbqj4sO5NSOoln4w49VwPprvJ6H+g9Q6MlAwHKBs0g2+hkWFrnK5G72WdoD/k HHJIN6Bwo4xL9uPcI0krf2P0725MYCByk7TqGVa5zJlfB2Iuci3iaoPN5NSYn00+7khs B3Aq5JIcc6eEe+dM9FOmRbupv+ZYhpNaOPVy4= Received: by 10.229.213.146 with SMTP id gw18mr2458412qcb.243.1288998031140; Fri, 05 Nov 2010 16:00:31 -0700 (PDT) Received: from kan.dnsalias.net (c-24-63-226-98.hsd1.ma.comcast.net [24.63.226.98]) by mx.google.com with ESMTPS id l14sm1867151qck.29.2010.11.05.16.00.29 (version=SSLv3 cipher=RC4-MD5); Fri, 05 Nov 2010 16:00:29 -0700 (PDT) Date: Fri, 5 Nov 2010 19:00:23 -0400 From: Alexander Kabaev To: Jeremie Le Hen Message-ID: <20101105190023.29e5d39d@kan.dnsalias.net> In-Reply-To: <20101105213905.GT30284@felucia.tataz.chchile.org> References: <20100803150545.GH14016@felucia.tataz.chchile.org> <20100803114651.651e0ea4@kan.dnsalias.net> <20100805191446.GJ14016@felucia.tataz.chchile.org> <20100919081406.GH6864@felucia.tataz.chchile.org> <20100919184146.GE2389@deviant.kiev.zoral.com.ua> <20100920162925.GL6864@felucia.tataz.chchile.org> <20100920192708.GK2389@deviant.kiev.zoral.com.ua> <20100927094651.GB57265@felucia.tataz.chchile.org> <20100927154457.GJ43070@deviant.kiev.zoral.com.ua> <20101005181804.GJ7536@felucia.tataz.chchile.org> <20101105213905.GT30284@felucia.tataz.chchile.org> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/B0AAXSDb_wmecMDrS8ZGrMP"; protocol="application/pgp-signature" Cc: Kostik Belousov , kan@freebsd.org, freebsd-hackers@freebsd.org Subject: Re: [PATCH] Add -lssp_nonshared to GCC's LIB_SPEC unconditionally X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2010 23:28:41 -0000 --Sig_/B0AAXSDb_wmecMDrS8ZGrMP Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 5 Nov 2010 22:39:06 +0100 Jeremie Le Hen wrote: > Hi Kib, >=20 > On Tue, Oct 05, 2010 at 08:18:04PM +0200, Jeremie Le Hen wrote: > >=20 > > On Mon, Sep 27, 2010 at 06:44:57PM +0300, Kostik Belousov wrote: > > > Hardcoding /usr/lib as the path to the library in the script looks > > > problematic. For the buidlworld, you are linking resulting > > > binaries with the host library, instead of the > > > buildworld-produced one. For lib32, it makes non-working > > > combination of 32/64 bit. > >=20 > > Sorry for the late reply, but I had to collect various evidences > > for my sayings and my development machine is reaaaaaaaaaaally slow. > >=20 > > In fact it seems the toolchain built for buildworld contains a ld(1) > > binary which invariably bases lookups for libraries in ${WORLDTMP}, > > even in case of an absolute path. I have two evidences of this: > > - Putting /usr/obj/usr/src/tmp/usr/lib/libssp_nonshared.a in > > /usr/obj/usr/src/tmp/usr/lib/libc.ld leads toolchain's ld(1) to > > use /usr/obj/usr/src/tmp/usr/obj/usr/src/tmp/usr/lib/libssp_nonshared.a; > > - I also verified this with a hand-wrought opensnoop-like DTrace > > script. >=20 > I dare to remind you about my patch. Do you have any other concerns? >=20 > Thanks. > Regards, > --=20 > Jeremie Le Hen >=20 > Humans are born free and equal. But some are more equal than others. > Coluche Hmm, I thought I did approve this patch already a long time agi, but since you asked: +.if defined(SHLIB_LDSCRIPT) && exists(${.CURDIR}/${SHLIB_LDSCRIPT}) this should be: +.if defined(SHLIB_LDSCRIPT) ditto for all other similar places. Otherwise I do not think we should hold the patch in queue ans should unleash it on unsuspecting public. --=20 Alexander Kabaev --Sig_/B0AAXSDb_wmecMDrS8ZGrMP Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iD8DBQFM1IyMQ6z1jMm+XZYRApYIAJ9UsbwPnV0dEub002Nk4OWVok7JQQCgvU9B L+lsEZA4M0qV4JCu5pOgqBM= =5elm -----END PGP SIGNATURE----- --Sig_/B0AAXSDb_wmecMDrS8ZGrMP--