From owner-svn-src-head@freebsd.org Tue Jun 19 23:57:10 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 289AE101703B for ; Tue, 19 Jun 2018 23:57:10 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CB3247C280 for ; Tue, 19 Jun 2018 23:57:09 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yb0-f176.google.com (mail-yb0-f176.google.com [209.85.213.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id 92551208E0 for ; Tue, 19 Jun 2018 23:57:09 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yb0-f176.google.com with SMTP id e16-v6so56425ybh.8 for ; Tue, 19 Jun 2018 16:57:09 -0700 (PDT) X-Gm-Message-State: APt69E0T94n1Arw7VWKN4WQQcnrCCJwEP3Yz1oC+fyvSV4ocW8DLabpF WQFBglruFqpx1r02X4SLrK1EMVprFWF1dZybFrN4JQ== X-Google-Smtp-Source: ADUXVKJ6jwQwyJm+9tU9EOODG5vhMINe9umzk3m+UByUSl/Vq9B/rQhJPFYwqx90lpilR9d/NK/Z5gbSy2nC2ukUuRo= X-Received: by 2002:a25:a05:: with SMTP id 5-v6mr9479358ybk.479.1529452628849; Tue, 19 Jun 2018 16:57:08 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Tue, 19 Jun 2018 16:56:38 -0700 (PDT) In-Reply-To: References: <201806170514.w5H5Epts050842@repo.freebsd.org> <77224f10-7633-1122-8099-466f2a35942f@FreeBSD.org> <4ad7ef96-e623-5ab8-dc47-c3178115ff24@FreeBSD.org> From: Eitan Adler Date: Tue, 19 Jun 2018 16:56:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335278 - head/bin/pwd To: Pedro Giffuni Cc: John Baldwin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 23:57:10 -0000 On 19 June 2018 at 12:57, Pedro Giffuni wrote: > > > On 19/06/2018 11:25, John Baldwin wrote: >> >> On 6/18/18 10:26 PM, Eitan Adler wrote: >>> >>> On 18 June 2018 at 10:57, John Baldwin wrote: >>>> >>>> On 6/16/18 10:14 PM, Eitan Adler wrote: >>>>> >>>>> Author: eadler >>>>> Date: Sun Jun 17 05:14:50 2018 >>>>> New Revision: 335278 >>>>> URL: https://svnweb.freebsd.org/changeset/base/335278 >>>>> >>>>> Log: >>>>> pwd: mark usage as dead >>>> >>>> You keep committing changes like this and ignoring e-mails about them. >>> >>> I replied both the first time and this time. I may have >>> (accidentally?) ignored similar emails though. The question I have is >>> other than the mild code churn what's the harm? >> >> It adds clutter. Also, fixing the tool means you fix all the places at >> once rather than slowly adding workarounds one by one. >> >>>> What broken compiler are you using that doesn't properly inherit __dead2 >>>> from the call to exit()? >>> >>> In this case, scan-build50 was getting annoyed. >> >> Does scan-build from LLVM 6.0 handle this correctly? If so, I'd say to >> just mark this warning as broken (and thus ignore it) for scan-build50 >> just as we ignore certain warnings from GCC 4.2.1 because they are >> broken-as-implemented. >> > FWIW, clang's scan-build is made to even more false positives and general > noise than the regular compiler warnings. > It is better to just ignore it unless it finds something real. I don't consider this a real harm, but I'll try and remember to ignore these in the future. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams