From owner-svn-src-head@freebsd.org Fri Apr 14 20:39:47 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AECFCD3A86B; Fri, 14 Apr 2017 20:39:47 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 772781F8C; Fri, 14 Apr 2017 20:39:47 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id c198so16534130pfc.0; Fri, 14 Apr 2017 13:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=irXVje+m8CLSJAb62ehT2qVpRpQqepcvon8JPA5q4cA=; b=Vh1a82+EpcqoVw9QVXhdnCub7Kf+15J/oVpgvxMfcslHFDXvb1VJPa3IE9JG4ehCz+ M5dlKRkXn/2OUJ6cy7Rpz9C3PwU1hwFi5FCk7B4DnDbutjFH791MD0am5fWyebuyd5Np cNsd9/kY4/JuFQGJqzsugEm9r/KSR4nbhAVlu0IvhnzXt5jEU7NyQAQ9aWtVKVqYLNuP 6lH/gn0FMm1vcPQuLIsXkUw/wsiBmjIF8E4IYFOJs1/Uyn8ug0JsZBSE+ecMwX6HKfO2 T/jlONxNbHoDc7N5KCbi4ZYC6s5AVNo+IfvDjcVqIJyXWrB7M+TgQoefnj4vzGyCu5EG DbiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=irXVje+m8CLSJAb62ehT2qVpRpQqepcvon8JPA5q4cA=; b=NRUCzFGIyrByGAHfqfAuemfB0qo0P6Grb7R9u//s9YrZOcjseWssP9ZXA/aPOD4TOI IjzJCh4RNlMbJ3OM4XQT0ZuUCmN0zn3eJFnkDL4V5Rt4Q14goFiGopBgSthfirhbh1kH 3PQugm1HQQBkgZzt8y/lWRHEMCtxfP7qb6qUC9eQQ6zoW1nBCbD9D/+AEJ/etzQr53ho CKFwfSmdsgIkfDCefvOCGpr2qTcZciF/z2thDz1VbYUlsHjx//FPLtTwV3ctck1svuEs UtN1ZTWExMeMaTCN3YWr2ma7iOiayNBI7ubYQ7GOowx2Y7QzBr04fMeYZIh8BPCnMQ9d x9dQ== X-Gm-Message-State: AN3rC/7guOCOemBDyAJzUGpU2myC3hDXersM7zJzY+Pp3tsZlWdDE9zb whVxJIdYXjNCbw== X-Received: by 10.99.135.193 with SMTP id i184mr8670201pge.120.1492202387036; Fri, 14 Apr 2017 13:39:47 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id f24sm4770477pfk.88.2017.04.14.13.39.45 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Apr 2017 13:39:45 -0700 (PDT) Subject: Re: svn commit: r316938 - head/sbin/savecore Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_215A0B22-5F85-4831-9C44-17E7863F09D3"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Fri, 14 Apr 2017 13:39:44 -0700 Cc: Slawa Olhovchenkov , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Ngie Cooper , Alan Somers Message-Id: <12820BAB-D8BA-4EDE-89BC-4BDB56B1E57A@gmail.com> References: <201704141941.v3EJfmCW003347@repo.freebsd.org> <20170414201431.GF20974@zxy.spb.ru> <0CAE4B1C-228B-4C71-86E9-4337753DFF74@lerctr.org> To: Larry Rosenman X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 20:39:47 -0000 --Apple-Mail=_215A0B22-5F85-4831-9C44-17E7863F09D3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 14, 2017, at 13:37, Larry Rosenman wrote: >=20 > On 4/14/17, 3:33 PM, "Ngie Cooper (yaneurabeya)" = wrote: >=20 >> On Apr 14, 2017, at 13:26, Larry Rosenman wrote: >>=20 >> On 4/14/17, 3:19 PM, "Ngie Cooper (yaneurabeya)" = = wrote: >>=20 >>> On Apr 14, 2017, at 13:14, Slawa Olhovchenkov = wrote: >>>=20 >>> On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: >>>=20 >>>> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper = wrote: >>>>> Author: ngie >>>>> Date: Fri Apr 14 19:41:48 2017 >>>>> New Revision: 316938 >>>>> URL: https://svnweb.freebsd.org/changeset/base/316938 >>>>>=20 >>>>> Log: >>>>> savecore: fix space calculation with respect to `minfree` in = check_space(..) >>>>>=20 >>>>> - Use strtoll(3) instead of atoi(3), because atoi(3) limits the >>>>> representable data to INT_MAX. Check the values received from >>>>> strtoll(3), trimming trailing whitespace off the end to maintain >>>>> POLA. >>>>> - Use `KiB` instead of `kB` when describing free space, total = space, >>>>> etc. I am now fully aware of `KiB` being the IEC standard for = 1024 >>>>> bytes and `kB` being the IEC standard for 1000 bytes. >>>>> - Store available number of KiB in `available` so it can be more >>>>> easily queried and compared to ensure that there are enough KiB = to >>>>> store the dump image on disk. >>>>> - Print out the reserved space on disk, per `minfree`, so = end-users >>>>> can troubleshoot why check_space(..) is reporting that there = isn't >>>>> enough free space. >>>>>=20 >>>>> MFC after: 7 weeks >>>>> Reviewed by: Anton Rang (earlier diff), cem = (earlier diff) >>>>> Tested with: positive/negative cases (see review); make tinderbox >>>>> Sponsored by: Dell EMC Isilon >>>>> Differential Revision: D10379 >>>>=20 >>>> The free space calculation is still uselessly conservative, because = it >>>> doesn't account for the fact that core dumps will always be either >>>> spare or compressed. The result is that savecore will frequently >>>> refuse to save corefiles even when there's plenty of space. I >>>> proposed removing the space check altogether in >>>> https://reviews.freebsd.org/D2587. However, I agreed to wait until >>>> after the compressed core dump feature was merged, because then = mostly >>>> accurate space checks will be possible. AFAIK the compressed core >>>> dump feature still hasn't been finished. >>>=20 >>> Is posible (in the future) to use multiple swaps (on multiple disks) >>> for save core dumps? >>=20 >> Multiple swap devices is already handled by savecore(8), if one = uses fstab(5) or dumpon(8). Otherwise, you must invoke savecore(8) on = individual devices. >>=20 >> As far as saving to multiple disks is concerned, I would hope that = one is using a redundancy capable filesystem (zfs) or RAID-like = technology (gmirror, graid, LSI Fusion=E2=80=99s RAID product line) to = stripe and/or mirror the data across multiple disks. >=20 > =E2=80=A6 >=20 >> How do I use multiple devices to have the system dump on all of my = swap? I got a message about not enough space, but there (I think) was = enough between multiple drives=E2=80=A6. >=20 > Something like: >=20 > - Create a zpool > - Mount zpool to /crashdumps > - Change dumpdir in /etc/rc.conf to be /crashdumps, e.g., echo = =E2=80=98dumpdir=3D/crashdumps=E2=80=99 >=20 > ? > HTH, > -Ngie >=20 > PS The issue with lack of space might be the issue that Alan = brought up earlier with compressed dumps and overly conservative free = space checks, or it might be the fact that dumpdir (default: /var/crash) = is full. >=20 >=20 > I was talking about the actual crashdump to swap by the system. = /var/crash has 10T of space (my root pool). If your memory is bigger than your swap, you=E2=80=99re unfortunately = not able to save the mini dump if the size of the saved pages exceed the = space on swap. I think this is where markj=E2=80=99s compressed dumps = feature will come in handy. Thanks! -Ngie --Apple-Mail=_215A0B22-5F85-4831-9C44-17E7863F09D3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8TOQAAoJEPWDqSZpMIYVIckP/1/wc/m+cB8E/xrSul7Da/3t rEEac5Wd87AcepXrjWINm76mV4ptWr2Wxob/1JH7xBC0tw3Tv8FcqKhsPRKW6Pyu phufjxc3yy1KZCZWRPhz6SA1k3hD3Q6zfnXbtxy13YH8M7CpLb78ni/wSmhuEorD VjJgdijY5y19f3JTfhw/FU3+5OOR/n+0058o5cEKavIZ6VWZmG2iQ4iujx808xpm V5q4OOVGlNNWXGIxGWnvea98dITdVIJYnUbW0ENLRAnxEcsFg0S0TWDFbBQA9qeR L3Co0SCfQaOw+nnPY8u84aiPqhaefrVzcn5iUr+M4qU9v3WPupj3Z0j2A5ZMExR9 19UQm6Aofm0ZnS1/Gp+wi7XLbMfxkhsVxlljLpRBR5q4KtWwttFwZijnLvdlYw0v zLiJqu0jCW5ZA+U3qKIXlU4uIqSmLj9iZEETA2/6J4SvcllMRI+raHgugIbHSBEl UlqFC/p40ByArQvzU4xWb2Ll8VR6iaKSWledkukKpRruHc0JU0h7GmIW4qzx1HlF Fsp9fzcTL1nAGJfqy3CW1SaBQ8d+kaw/9zLGSSRpzHkF6FUYl20+TWIxiB1luB3y 8UcYFNJdYh5NjXv2gybPvjogueU48ZceBQ9t3UM1ZKDvKSt2Tb/kzpGiXP5kf45t /Xw83eOleAC2Tq3Egj/t =288l -----END PGP SIGNATURE----- --Apple-Mail=_215A0B22-5F85-4831-9C44-17E7863F09D3--