From owner-svn-src-all@freebsd.org Wed Sep 23 16:37:13 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30F48A063EE for ; Wed, 23 Sep 2015 16:37:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk0-f180.google.com (mail-qk0-f180.google.com [209.85.220.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0F411D55 for ; Wed, 23 Sep 2015 16:37:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qkcf65 with SMTP id f65so19427215qkc.3 for ; Wed, 23 Sep 2015 09:37:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=jok5jcOh2+I3QNdd4WKVXFNWkEn2pVJNLCS720Dl+Do=; b=fnDAdoFMjTLSy0zHTFKlK+plWHImg/SBZrMyXU45IRg/UBKnDJK/kd8fyMRIDruIOZ iDZkKeAMCFcoNmisG5bkdApF2E7je61YvcQDYaM0dDR5kcJh4eAFa9zNYPwsqsS4zaSJ SWmm3btFAyUoZaxKuQ15VGJJ2ypxAiEJ0NKNt4ZhlYyNbPAUZBGHCey3BlfVnxrDRtKO 7Kf7UWM0bkwiHRHxN7sPNrUjZJv4zirZbomFaJZ3HrT3AtztaGy7gIg/V8Qqhe3r4MPg Prl0QK9Cft1StPk9gKljoGfDLcC1breEEs/5Vz7Nk4abyiQIzTcXGbR5p5d6vQOkMcsN LrBg== X-Gm-Message-State: ALoCoQmW7yeiNBw+JXNtMIj4Kn4lK4ivdnwvbaE23zQ7V6/2srOoM2edAShqi9gsOFfrv++A4RO1 MIME-Version: 1.0 X-Received: by 10.55.198.201 with SMTP id s70mr37338477qkl.42.1443026225618; Wed, 23 Sep 2015 09:37:05 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.140.80.167 with HTTP; Wed, 23 Sep 2015 09:37:05 -0700 (PDT) X-Originating-IP: [40.140.178.190] In-Reply-To: <56022B4C.7070407@FreeBSD.org> References: <201508270152.t7R1qks4074549@repo.freebsd.org> <56022B4C.7070407@FreeBSD.org> Date: Wed, 23 Sep 2015 09:37:05 -0700 X-Google-Sender-Auth: w2kGISzeTXOBkV_A-zNXxn5tKWk Message-ID: Subject: Re: svn commit: r287185 - head/share/mk From: Warner Losh To: Bryan Drewery Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 16:37:13 -0000 I've been making a pass through the tree and found that FOO.${MK_BAR}+= a b c vs .if ${MK_BAR} != "no" FOO+= a b c .endif simpler to understand. This commit is one small slice of that which I could commit. These files have a high enough churn rate that I'm not always able to keep up enough to push my changes. So this was part of what I could do today to start to reduce my patch-set. This was discussed on arch@freebsd.org a while ago. Warner On Tue, Sep 22, 2015 at 9:32 PM, Bryan Drewery wrote: > On 8/26/15 6:52 PM, Warner Losh wrote: > > Author: imp > > Date: Thu Aug 27 01:52:45 2015 > > New Revision: 287185 > > URL: https://svnweb.freebsd.org/changeset/base/287185 > > > > Log: > > For each FOO in FILESLISTS, append the value of FOO.yes, sort, and > > remove duplicates. > > > > Modified: > > head/share/mk/bsd.files.mk > > > > Modified: head/share/mk/bsd.files.mk > > > ============================================================================== > > --- head/share/mk/bsd.files.mk Thu Aug 27 01:02:01 2015 > (r287184) > > +++ head/share/mk/bsd.files.mk Thu Aug 27 01:52:45 2015 > (r287185) > > @@ -10,6 +10,9 @@ ____: > > FILESGROUPS?= FILES > > > > .for group in ${FILESGROUPS} > > +# Add in foo.yes and remove duplicates from all the groups > > +${${group}}:= ${${group}} ${${group}.yes} > > +${${group}}:= ${${group}:O:u} > > buildfiles: ${${group}} > > .endfor > > > > > > What is this for? > > -- > Regards, > Bryan Drewery >