From owner-freebsd-current  Thu Feb 14 23:31:45 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id B4C4237B405; Thu, 14 Feb 2002 23:31:41 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA13697;
	Fri, 15 Feb 2002 18:31:30 +1100
Date: Fri, 15 Feb 2002 18:34:35 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Daniel Eischen <eischen@pcnet1.pcnet.com>
Cc: Kevin Day <toasty@shell.dragondata.com>, <current@FreeBSD.ORG>,
	<bde@FreeBSD.ORG>
Subject: Re: function name collision on "getcontext" with ports/editors/joe
In-Reply-To: <Pine.GSO.4.10.10202150140550.29176-100000@pcnet1.pcnet.com>
Message-ID: <20020215181603.Y17221-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Fri, 15 Feb 2002, Daniel Eischen wrote:

> Finally getting buildworld to work again...
>
> More problems in the kernel though.  ucontext_t is used as a
> parameter to sigreturn (and getsetcontext soon), so it is
> referenced in <sys/sysproto.h>.  Lots of stuff includes
> <sys/sysproto.h>.  Do we,
>
>   a) Include <sys/ucontext.h> conditionally from
>      <sys/signal.h> based on _KERNEL, or
>   b) Change makesyscalls.sh to emit #include\t<sys/ucontext.h>
>      when generating sysproto.h, or,
>   c) Add includes for <sys/ucontext.h> to all files that
>      include <sys/sysproto.h>

None of the above)  Change syscalls.master in the same way as <signal.h>
to use "struct __ucontext *" instead of "ucontext_t *", and maybe
forward-declare "struct __ucontext" in <sys/signal.h> so that sysproto.h
can see it (sysproto.h really shouldn't include <sys/signal.h>, but it
doesn, and I think the forward declaration isn't be automatically
generated [yet?]).

If you change the sigreturn line in syscalls.master, please fix the name
of the parameter there and in the functions (it is still sigcntxp,
but should have been scp and should now be ucp).  Also try adding `const'.
Almost all of the pointers to input parameters in syscalls.master are
missing `const' and adding them tends to require const poisoning all
over the kernel, but `const' should be used for at least syscalls newer
than C90.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message