From owner-svn-src-all@freebsd.org Thu Aug 31 16:18:05 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CCCEE015D6; Thu, 31 Aug 2017 16:18:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A4E4283027; Thu, 31 Aug 2017 16:18:04 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v7VGHxmD038378 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 31 Aug 2017 19:17:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v7VGHxmD038378 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v7VGHxQD038377; Thu, 31 Aug 2017 19:17:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 31 Aug 2017 19:17:59 +0300 From: Konstantin Belousov To: Alexander Motin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323032 - in head: share/man/man4 sys/amd64/conf sys/conf sys/dev/ntb/ntb_hw sys/i386/conf sys/modules/ntb sys/modules/ntb/ntb_hw sys/modules/ntb/ntb_hw_intel sys/modules/ntb/ntb_hw_plx Message-ID: <20170831161759.GW1700@kib.kiev.ua> References: <201708302116.v7ULGWge035544@repo.freebsd.org> <20170831160525.GT1700@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 16:18:05 -0000 On Thu, Aug 31, 2017 at 07:12:38PM +0300, Alexander Motin wrote: > On 31.08.2017 19:05, Konstantin Belousov wrote: > > On Wed, Aug 30, 2017 at 09:16:32PM +0000, Alexander Motin wrote: > >> Author: mav > >> Date: Wed Aug 30 21:16:32 2017 > >> New Revision: 323032 > >> URL: https://svnweb.freebsd.org/changeset/base/323032 > >> > >> Log: > >> Add NTB driver for PLX/Avago/Broadcom PCIe switches. > >> > > In ntb_plx_attach(), BAR 0 and all found BARs 2-5 are explicitely > > remapped as uncacheable. Why is it needed ? Does rman on x86 > > ever map any resource as not non-cacheable ? > > Hmm. May be not. I added those to be sure while debugging one issue, > which appeared unrelated. Shall I remove them, expecting non-cacheable > to be default there? Unless you need some other mode on the windows, e.g. write-combining, I do not see a use for re-applying the same mapping attributes. The pmap function is somewhat optimized, but it still had to iterate over the page table.