From owner-freebsd-wireless@FreeBSD.ORG Sun Jul 3 06:22:04 2011 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D51FC1065670 for ; Sun, 3 Jul 2011 06:22:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9499B8FC13 for ; Sun, 3 Jul 2011 06:22:04 +0000 (UTC) Received: by gyf3 with SMTP id 3so2188015gyf.13 for ; Sat, 02 Jul 2011 23:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Xbc82mf9LAxaeNw+2YfAvybnrNCUoa45gjIJ6dGfbbs=; b=YZluARFL44HEZAvkTT5wotOz9Jk/+DbgYrjCBuhV4HAfolSlomlz4YxD1HPiomgat9 DHysGhm2bHcGmPC52wukELFVh3w6JwMz6Q4doOvheIP/ETORkUoWgk2t/t4GiTqMaXvW 0WuBmRKLL1MELV5CbL426N/DVjumkVsw6OL5Y= MIME-Version: 1.0 Received: by 10.150.160.21 with SMTP id i21mr4404878ybe.57.1309674122957; Sat, 02 Jul 2011 23:22:02 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.151.45.11 with HTTP; Sat, 2 Jul 2011 23:22:02 -0700 (PDT) In-Reply-To: References: Date: Sun, 3 Jul 2011 14:22:02 +0800 X-Google-Sender-Auth: V_1G3OAK8-WpabZZQl3jLbEo3kA Message-ID: From: Adrian Chadd To: ss griffon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org Subject: Re: Patch to move global ath alq register logging to per device X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jul 2011 06:22:04 -0000 Hi! Good work so far. Here's the problems I've found: * There's a couple of formatting problems, tabs where there shouldn't be, etc. That's no biggie, we can go over that later! * if_ath_sysctl.c doesn't "know" about the alq sysctl attach routine, because it doesn't include ah_osdep.h * ah_osdep.h should only be included by the HAL code, not by the sysctl attach routine code. The problem-that-isn't-a-problem: * the ALQ bits in the ath_hal struct aren't conditionally compiled based on the ALQ debug #define. But part of me wants to maintain a consistent public API regardless of what debug/non-debug options are compiled in. (I know that maintaining an ABI isn't so important these days however.) So let's leave it unconditionally compiled where it is, and we can potentially stuff it in ath_hal_private later on if needs be. I'm not sure about the "right" way of doing the sysctl attach. The sysctl attach routine should live in ah_osdep.c; the question is how do we export that as part of the HAL layer to the driver itself. We can't just include ah_osdep.h (and include opt_ah.h too) because that'd be breaking whatever resemblance of "layering" still exists in this driver. Perhaps what we should do is export the sysctl attach function in ath_hal/ah.h. (That's fine, as it just means it needs to exist in ah_osdep.c for whatever other OSes want to port this code over later.) For the non-ALQ case, we can just compile up an empty function. What do you think? Thanks, Adrian On 2 July 2011 14:03, ss griffon wrote: > This enables register logging for each ath device. =A0The default log > path is /tmp/ath_hal.log but can be changed with the sysctl > dev.ath..hal.alq_logfile. =A0Let me know if there are any > issues. > > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.or= g" > >