From owner-cvs-all Tue Jan 21 10:47:47 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1F4037B405 for ; Tue, 21 Jan 2003 10:47:45 -0800 (PST) Received: from mail.gmx.net (pop.gmx.net [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 2EF8243F13 for ; Tue, 21 Jan 2003 10:47:44 -0800 (PST) (envelope-from tmoestl@gmx.net) Received: (qmail 12688 invoked by uid 0); 21 Jan 2003 18:47:43 -0000 Received: from p508E6C12.dip.t-dialin.net (HELO galatea.local) (80.142.108.18) by mail.gmx.net (mp018-rz3) with SMTP; 21 Jan 2003 18:47:43 -0000 Received: from localhost ([127.0.0.1] helo=galatea.local) by galatea.local with esmtp (Exim 4.12 #1) id 18b3Sw-0000vD-00; Tue, 21 Jan 2003 19:49:42 +0100 Received: (from tmm@localhost) by galatea.local (8.12.6/8.12.6/Submit) id h0LInUAe003546; Tue, 21 Jan 2003 19:49:30 +0100 (CET) Date: Tue, 21 Jan 2003 19:49:30 +0100 From: Thomas Moestl To: Sam Leffler Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sparc64/sparc64 iommu.c Message-ID: <20030121184930.GA337@crow.dom2ip.de> Mail-Followup-To: Sam Leffler , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200301211708.h0LH8Mn5005942@repoman.freebsd.org> <04bf01c2c178$4cc3eca0$52557f42@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04bf01c2c178$4cc3eca0$52557f42@errno.com> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 2003/01/21 at 10:09:54 -0800, Sam Leffler wrote: > > Fix iommu_dvmamap_sync(): it was still operating as if the BUS_DMASYNC_* > > constants where flag bits (as in NetBSD), although they are > consecutively > > numbered in FreeBSD. This would cause unnecessary flushing in the > > BUS_DMASYNC_POSTWRITE case, but was otherwise mostly harmless. [...] > > Gack! Do you see a good reason for this? This seems like something that'll > cause really hard to find bugs when porting drivers (though one should > probably not use more than one flag per op). I'd really like to see these > constants have the same value on all systems. Moving in the direction of NetBSD definitely makes sense here, I just wanted to fix this breakage as quickly as possible for now. - Thomas -- Thomas Moestl http://www.tu-bs.de/~y0015675/ http://people.FreeBSD.org/~tmm/ PGP fingerprint: 1C97 A604 2BD0 E492 51D0 9C0F 1FE6 4F1D 419C 776C To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message