From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 11 03:50:10 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C9E451065696 for ; Mon, 11 Jan 2010 03:50:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8CAA18FC2D for ; Mon, 11 Jan 2010 03:50:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0B3oAqM012001 for ; Mon, 11 Jan 2010 03:50:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0B3oA1E012000; Mon, 11 Jan 2010 03:50:10 GMT (envelope-from gnats) Resent-Date: Mon, 11 Jan 2010 03:50:10 GMT Resent-Message-Id: <201001110350.o0B3oA1E012000@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rob Farmer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EBE331065676 for ; Mon, 11 Jan 2010 03:49:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id C0EA88FC23 for ; Mon, 11 Jan 2010 03:49:42 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0B3ngSc014770 for ; Mon, 11 Jan 2010 03:49:42 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o0B3ngpt014769; Mon, 11 Jan 2010 03:49:42 GMT (envelope-from nobody) Message-Id: <201001110349.o0B3ngpt014769@www.freebsd.org> Date: Mon, 11 Jan 2010 03:49:42 GMT From: Rob Farmer To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/142706: [PATCH] ftp/cftp Fix local buffer overflow, update WWW, take maintainership X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2010 03:50:11 -0000 >Number: 142706 >Category: ports >Synopsis: [PATCH] ftp/cftp Fix local buffer overflow, update WWW, take maintainership >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon Jan 11 03:50:10 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Rob Farmer >Release: 9.0-CURRENT >Organization: >Environment: FreeBSD peridot.predatorlabs.net 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r201657: Wed Jan 6 09:49:06 PST 2010 robert@peridot.predatorlabs.net:/usr/obj/usr/src/sys/PERIDOT i386 >Description: * Fix local buffer overflow (obtained from NetBSD) * Update WWW * Take maintainership >How-To-Repeat: >Fix: Patch attached with submission follows: diff -ruN cftp.old/Makefile cftp/Makefile --- cftp.old/Makefile 2010-01-09 23:28:02.000000000 -0800 +++ cftp/Makefile 2010-01-09 23:38:00.000000000 -0800 @@ -7,12 +7,12 @@ PORTNAME= cftp PORTVERSION= 0.12 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= ftp ipv6 MASTER_SITES= ftp://ftp.giga.or.at/pub/nih/cftp/ \ ftp://sunsite.univie.ac.at/pub/nih/cftp/ -MAINTAINER= ports@FreeBSD.org +MAINTAINER= rfarmer@predatorlabs.net COMMENT= Comfortable FTP, a full screen ftp client GNU_CONFIGURE= yes diff -ruN cftp.old/files/patch-readrc.c cftp/files/patch-readrc.c --- cftp.old/files/patch-readrc.c 1969-12-31 16:00:00.000000000 -0800 +++ cftp/files/patch-readrc.c 2010-01-09 23:33:38.000000000 -0800 @@ -0,0 +1,11 @@ +--- readrc.c.orig 2010-01-09 23:30:28.000000000 -0800 ++++ readrc.c 2010-01-09 23:31:10.000000000 -0800 +@@ -46,7 +46,7 @@ + char b[8192], *p, *tok, *q, *home; + char *user, *pass, *host, *port, *wdir; + +- if ((home=getenv("HOME")) == NULL) ++ if ((home=getenv("HOME")) == NULL || strlen(home) > sizeof(b)-9) + home = ""; + sprintf(b, "%s/.cftprc", home); + diff -ruN cftp.old/pkg-descr cftp/pkg-descr --- cftp.old/pkg-descr 2010-01-09 23:28:02.000000000 -0800 +++ cftp/pkg-descr 2010-01-09 23:36:03.000000000 -0800 @@ -4,4 +4,5 @@ fullscreen representation of the remote directory so you can easily choose what to get or where to go. -WWW: http://ftp.giga.or.at/pub/nih/cftp/ +WWW: http://nih.at/cftp/ + >Release-Note: >Audit-Trail: >Unformatted: