Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 Sep 2022 09:32:32 -0400
From:      Ed Maste <emaste@freebsd.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        Gordon Bergling <gbe@freebsd.org>, src-committers@freebsd.org,  dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: f0d4c2afd65f - main - pmc(3): Correct some typos in event descriptions
Message-ID:  <CAPyFy2Ah4-=r2vA5tHR9k7%2BOnPPigZdkzrhDxkKcTtG6b_2AYg@mail.gmail.com>
In-Reply-To: <05b97d9c-ff1d-0da2-ee22-0c054e853a77@FreeBSD.org>
References:  <202209041052.284Aqvu2007702@gitrepo.freebsd.org> <05b97d9c-ff1d-0da2-ee22-0c054e853a77@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 7 Sept 2022 at 13:41, John Baldwin <jhb@freebsd.org> wrote:
> > ---
> >   lib/libpmc/pmu-events/arch/x86/broadwell/pipeline.json        | 4 ++--
> >   lib/libpmc/pmu-events/arch/x86/broadwellde/pipeline.json      | 4 ++--
> >   lib/libpmc/pmu-events/arch/x86/broadwellx/pipeline.json       | 4 ++--
> >   lib/libpmc/pmu-events/arch/x86/cascadelakex/uncore-other.json | 2 +-
> >   lib/libpmc/pmu-events/arch/x86/silvermont/pipeline.json       | 4 ++--
> >   lib/libpmc/pmu-events/arch/x86/skylakex/uncore-other.json     | 2 +-
>
> I think these files are actually 3rd party (and should really be under
> contrib/ in that case?) so probably shouldn't be changed.  Maybe you can
> send the changes upstream to Linux instead?

Yes, these come from Linux and the fixes should be sent there. The
process is a bit cumbersome but at least well documented; I've done it
for a couple of pmu-events files before, e.g.
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=28396b7df09b9565f404591c9945eac43526cb3f

The process is documented in the Linux source tree at
Documentation/process/submitting-patches.rst



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2Ah4-=r2vA5tHR9k7%2BOnPPigZdkzrhDxkKcTtG6b_2AYg>