From owner-freebsd-geom@FreeBSD.ORG Mon Sep 17 16:50:11 2007 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 82D6816A46B for ; Mon, 17 Sep 2007 16:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7E42413C468 for ; Mon, 17 Sep 2007 16:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l8HGoBLw073291 for ; Mon, 17 Sep 2007 16:50:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l8HGoBbE073290; Mon, 17 Sep 2007 16:50:11 GMT (envelope-from gnats) Date: Mon, 17 Sep 2007 16:50:11 GMT Message-Id: <200709171650.l8HGoBbE073290@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Pete Cc: Subject: Re: kern/115572: [gbde] gbde partitions fail at 28bit/48bit LBA addressing boundary X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Pete List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2007 16:50:11 -0000 The following reply was made to PR kern/115572; it has been noted by GNATS. From: Pete To: bug-followup@FreeBSD.org Cc: sos@deepcore.dk Subject: Re: kern/115572: [gbde] gbde partitions fail at 28bit/48bit LBA addressing boundary Date: Mon, 17 Sep 2007 18:30:11 +0200 Does anyone know if Søren Schmidt's patch (repeated below) is safe to use, and if it is, when it will be commited? I'm also experiencing this problem, but I haven't dared to try the patch yet. The patch: --- ata-all.c 23 Feb 2007 16:25:08 -0000 1.279 +++ ata-all.c 19 Aug 2007 09:25:58 -0000 @@ -738,7 +738,7 @@ > atadev-flags &= ~ATA_D_48BIT_ACTIVE; - if ((request->u.ata.lba >= ATA_MAX_28BIT_LBA || + if (((request->u.ata.lba + request->u.ata.count) >= ATA_MAX_28BIT_LBA || > request-> u.ata.count256) && > atadev-param.support.command2 & ATA_SUPPORT_ADDRESS48) {