From owner-freebsd-stable  Sun Sep  2 20:11:52 2001
Delivered-To: freebsd-stable@freebsd.org
Received: from nova.fnal.gov (nova.fnal.gov [131.225.121.207])
	by hub.freebsd.org (Postfix) with ESMTP id 2EAAA37B401
	for <freebsd-stable@freebsd.org>; Sun,  2 Sep 2001 20:11:48 -0700 (PDT)
Received: from localhost (tez@localhost)
	by nova.fnal.gov (8.9.3+Sun/8.9.3) with ESMTP id WAA27779
	for <freebsd-stable@freebsd.org>; Sun, 2 Sep 2001 22:11:43 -0500 (CDT)
X-Authentication-Warning: nova.fnal.gov: tez owned process doing -bs
Date: Sun, 2 Sep 2001 22:11:42 -0500 (CDT)
From: Tim Zingelman <zingelman@fnal.gov>
X-Sender:  <tez@nova.fnal.gov>
To: <freebsd-stable@freebsd.org>
Subject: Re: ipfilter multicast loopback bug with FreeBSD (fwd)
Message-ID: <Pine.GSO.4.30.0109022205220.27274-100000@nova.fnal.gov>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

Can I talk anyone into committing this change and MFC'ing it?  I'd really
like to see this bug disappear before 4.4-RELEASE.  If you need details,
email me, and I can forward the whole history... essentially without this
patch, looped back multicasts get the last byte of ip address corrupted.

As indicated below, Darren Reed has applied the patch to the ipfilter
sources.  But the change has not gotten into the FreeBSD source tree.

 - Tim

---------- Forwarded message ----------
Date: Sun, 02 Sep 2001 00:52:42 +1000 (EST)
From: Darren Reed <darrenr@reed.wattle.id.au>
To: Tim Zingelman <zingelman@fnal.gov>
Subject: Re: ipfilter multicast loopback bug with FreeBSD

In some email I received from Tim Zingelman, sie wrote:
> Sorry to be a pest, but I wanted to remind you that this bug/patch is
> still awaiting your analysis/approval.  Thanks!  - Tim
>
> ---------- Forwarded message ----------
> Date: Wed, 22 Aug 2001 12:41:25 +0200 (CEST)
> From: Frank Volf <volf@oasis.IAEhv.nl>
> To: Tim Zingelman <zingelman@fnal.gov>
> Cc: ipfilter@coombs.anu.edu.au, Frank Volf <volf@oasis.IAEhv.nl>
> Subject: Re: ip multicast loopback w/ipfilter - bug in FreeBSD
>
>
> Assuming that you are using a recent IP Filter, please try the following
> patch:
>
> --- ip_fil3.4.20.dist/fil.c	Wed Jul 18 15:30:32 2001
> +++ ip_fil3.4.20/fil.c	Wed Aug 22 12:40:09 2001
> @@ -803,7 +803,7 @@
>  	/*
>  	 * disable delayed checksums.
>  	 */
> -	if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA) {
> +	if (out && (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA)) {
>  		in_delayed_cksum(m);
>  		m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
>  	}
>
> Frank

I've applied the patch to ipfilter sources.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message