From owner-svn-src-all@freebsd.org Tue Mar 20 16:41:50 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C4BDCF5B470; Tue, 20 Mar 2018 16:41:49 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 55F187B26B; Tue, 20 Mar 2018 16:41:49 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x22f.google.com with SMTP id e7so3136581iof.2; Tue, 20 Mar 2018 09:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=XNRX24Lr2qNiBKv0vWgq5fOvq9amWmfEWIeFf1/YL5U=; b=usLEvQ5RdDvg+yyBJzV8KsUikG/kNNCPjqQmvzaoM5bf849OhGaohJinWBqxquk/uh 7j+5eJNTaQorNeeq0RFwMWNGgnlt7ta8sS34EDh0ntjEn5jegSse9DG4/sAuo3XlN6MW vlUC6u8UHX3WvVkkMybD0smJ8uvPjYzV+qzBqzPBu9K0+EpjTEgo355ybTntIx7aHNuj 2HmihtmbjAQ3A2T/D1xsUucYBIOT2CI1DUCGrlBeDwig17ypZIlBU83dYUeQv6U9/whl INECy5ACFFZ9J2Za+Y0oIHVtRwFzrDstFAoCfshCDe/GSFLotxWg0Hdp+s1WGGhQKgFe tdwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=XNRX24Lr2qNiBKv0vWgq5fOvq9amWmfEWIeFf1/YL5U=; b=LxP1m1t7HZJ0dxoq4lpXbMEuS8MaBuzLSwmFAViCiaJVKKRIYgyM9NytpGLcX7LqYa fGeWOU9DACzcQIXOSlQEP8iulxflYGpn1Ww2L1B2QD1BZ8KHoD4RRXmTxMKLjjdlx9Fk otIjqjgHR6okbRPIx1DH0f+bTf3l8L+MaaUFbTW4g8LVHXdOi7R0L/AJPSo7lC0FRQ43 mQzoebF8d4ejTZ9dvMVCg1lHYdjQNlwt3zWCg4nE44rmh0Rhn32azrtfEoG/yMU/cs9m T8U98LR8XOd0PLDM2kh1PKIbR4zETNvAjj/SavgwFjsBC3iO4ytfGtGXrY+D6oS3wMPW GQeA== X-Gm-Message-State: AElRT7FpS0Kt6T45258ayikBXb1JKN4OBe3pHGZ+lPjeraTF/G+xi4Nx XRFPv/tOlHogo8WA6S2WpbpZOXftG08QNUg8qQo= X-Google-Smtp-Source: AG47ELtPBEBhLHPPu7H3uCp8lXvZK9+L0SDdNMY7B2sb7H5wSf5we02yZSVH5fS5pdNSkMMDICWnPfITt2hzNUwgCBM= X-Received: by 10.107.134.85 with SMTP id i82mr16444659iod.210.1521564107514; Tue, 20 Mar 2018 09:41:47 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.163.13 with HTTP; Tue, 20 Mar 2018 09:41:27 -0700 (PDT) In-Reply-To: <20180320183744.S950@besplex.bde.org> References: <201803192126.w2JLQW0N039356@repo.freebsd.org> <20180320183744.S950@besplex.bde.org> From: Ed Maste Date: Tue, 20 Mar 2018 12:41:27 -0400 X-Google-Sender-Auth: uFP1w7WQxSuxF4KDkQWOWAp3MEg Message-ID: Subject: Re: svn commit: r331226 - in head/sys: amd64/linux amd64/linux32 i386/linux To: Bruce Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 16:41:50 -0000 On 20 March 2018 at 04:19, Bruce Evans wrote: > > It is preferable to have a well-chosen (short...) prefix. The linux > emulator mostly uses l_ for internal names. That is a bit too short > for external names. l_ is too short. The only reasonable alternative is probably lnx_ but saving two characters seems does not seem worth it. > 'elf_' is an example of a well-chosen prefix. Not for Linux-specific things. There are currently three copies of these functions, and I'm going to move them so they can be shared by the Linuxulator on all appropriate archs. > I don't like the style of putting the verb last in names, but it goes well > with putting prefixes first. Here the verb placement style is random -- > the verb is last in ...handler_set and ...elf_fixup, but not last in > ...copyout_strings. These names are consistent with the sysentvec names. sv_copyout_strings = linux_strings_copyout seems confusing for no real benefit. > Names without any prefix are likely to have had the verb first, and now > in the middle. It should probably not be plural either. This could be linux_trap_translate instead.