From owner-freebsd-stable@FreeBSD.ORG Tue Apr 23 07:45:03 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 82934EE7; Tue, 23 Apr 2013 07:45:03 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ea0-x233.google.com (mail-ea0-x233.google.com [IPv6:2a00:1450:4013:c01::233]) by mx1.freebsd.org (Postfix) with ESMTP id E6B541DB2; Tue, 23 Apr 2013 07:45:02 +0000 (UTC) Received: by mail-ea0-f179.google.com with SMTP id h10so103310eaj.24 for ; Tue, 23 Apr 2013 00:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=oszkgJ1M2EtrVCOqHjIB+HU9e0gsjqDn/lNrcj99w4o=; b=MuN+l3R48t8f9CFRowYC0TxktQc1PlWNx2jaLnxvg0hvc7vXRwH2NOmC7Yu8Cyc3/Y nlNVr/uSmtx4S4DL5IYwJjOskl2EnT+7+dnoAwhap5tPCNEbzZ2xQhQTVeyGNWyUZ+r5 lg50PdxUOW8o84Mc1xVJ9vB/HxpyS9Wa1Xmq5SWqHsvuMzpwdNbspdtLPA1/QftTDMcG 5RygckBhLDtNi0FLunMnbjylxQJpuBKHQ1tIMTKMy8GdBVdj/SzMm5I2CCJdsx0K3aPc UpcNfPU//HJaBiQdo/OkamB/huelHoh8nC+fuQ3recNYgH3EwaXMz2BnQp3j+4zwvKoO Z8DA== X-Received: by 10.14.9.71 with SMTP id 47mr4152241ees.21.1366703102001; Tue, 23 Apr 2013 00:45:02 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (mavhome.mavhome.dp.ua. [213.227.240.37]) by mx.google.com with ESMTPS id d47sm45068909eem.9.2013.04.23.00.44.59 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Apr 2013 00:45:00 -0700 (PDT) Sender: Alexander Motin Message-ID: <51763BF9.2000506@FreeBSD.org> Date: Tue, 23 Apr 2013 10:44:57 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130413 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jeremy Chadwick Subject: Re: ada(4) and ahci(4) quirk printing References: <20130422051452.GA2148@icarus.home.lan> In-Reply-To: <20130422051452.GA2148@icarus.home.lan> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Kenneth Merry , freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 07:45:03 -0000 On 22.04.2013 08:14, Jeremy Chadwick wrote: > I've written the following patches and done the following testing (see > the results.*.txt files): > > http://jdc.koitsu.org/freebsd/quirk_printing/ > > Important: these are against stable/9 r249715. > > Folks are welcome to try these; I've tested about as best as I can. > > Questions/comments for Alexander and Kenneth: > > 1. I'm not sure if the location of where I added the printf() code is > correct or not, It seems fine for me. > 2. Not sure if loader.conf(5) forced-quirks would show up here or not, As I see, they will. > 3. It would be nice to have the same for SCSI da(4). I took a stab at > this but the printing code I wrote never got called (or the quirks entry > I added wasn't right, not sure which), > > 4. I strongly believe quirk printing should be shown *without* verbose > booting. I say this because I noticed some of the CAPAB printf()s only > get shown if bootverbose is true. In fact, it's what prompted me to > open PR 178040 ("My Intel 320 and 510-series SSDs don't show 4K quirks, > yet advertise 512 logical and physical in IDENTIFY?! PR time!"). Let me disagree. bootverbose keeps dmesg readable for average user, while quirks are specific driver workarounds and their names may confuse more then really help. If every driver print its quirks, dmesg would be two times bigger. There is bootverbose for it. -- Alexander Motin