From nobody Sun Mar 24 19:27:15 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V2mKj2Mtzz5GHst; Sun, 24 Mar 2024 19:27:21 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V2mKj1bMHz4bR5; Sun, 24 Mar 2024 19:27:21 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711308441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vUXdFmzbiBfs2V8C/Y5Lxzu7uah7nU79q2S0L/KWvkM=; b=aAlV8cWC8gqrRQa8725t9nGfcv0yPOFxp0xUpJeHpg6zUQtmDNGgmw1s4F+VTv4w87ijXp WybUsDwrQkl0+eEBJb5/b/sihlUhfZjfCqbOnPapBDo87MZKN9vwuAEEo58Q1BkQ5EsCs+ XR8GDM1vvE85zKkT/jdppNkeFb52AE5ENU6ZoyL95nOBI5n+w80qbKWqN56GHgSfg6CLMr ptSzzEYh6SRMqeq96VZ5OycKhlyDrmYz7XZhYjwfIds2b6afgrFH7qOCMhP5LFgX6fglDt MH7w7Vjo9h+zTADhEHfJQVlUEDxECOFb++tydrxgI3gw4iC3syWYgpH7oYNcMQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711308441; a=rsa-sha256; cv=none; b=dcpYtjG0DR/PUtXl1/bgKoVdY58tTDfb+VBJotKF+2fMF8JuPD8ncYvbQcHbbjf4fzDyMJ 3lnw4tc87ZhQc91SiOJg+NAQblR7l+hG4fAbx9Alya88VMA+b56IihB31vDGA4Y5zvn1Qt ezo03HNNbad/QPZlktC1Hh3GkuRBkSVYHHenzCyg8mM6/IEpn63X4f5vPGC3DkBVzNmL8J iQnGr85dRXTfT8XHjSrvy9iev7qnGjjvks2VBUlrSIzy67FptVXdL1R3Ly+RVSZlfl0Xlf FGKKt17+iF+MBJCdNhzEaLOCRZg6TClx5VgUTYPS0karONUd7Rzw1x/oeXhs7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711308441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vUXdFmzbiBfs2V8C/Y5Lxzu7uah7nU79q2S0L/KWvkM=; b=q/i0aLyzg/c8Z125HJMUxgoKAICRWyRPLiHGZdhPhEaL7bjYFr41uUSBxIkAHYo47lG6Pt wz48HGLWaLbhfoWewIqk+kBmRxblCN5JZvXzpTtAegIiG9h9Nwi3sf49BO/K+CxV6jA8sd hQbr2zBuBPW/jZG+c1JiKGasx9xH2mdsZ3osIw7DVZJeXCtu+NRXKzr2yYLvGWY6oZ6wWI XeumTnL8mE2kUINggRId7zxpY+uZ43nsrmSX2lsaG0Z5QGmefGzoW7HBQSglnJcLUt7exA F7S1IYueC9S9lyOVGSqAmZ7m+mZTew/0QZF9vBO4Df2RpgVknDDOjenfrbxkIg== Received: from hal.tijl.coosemans.org (unknown [IPv6:2a02:a03f:994e:2800:1485:af74:6f13:f164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V2mKh2TwRz1Lb2; Sun, 24 Mar 2024 19:27:20 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Sun, 24 Mar 2024 20:27:15 +0100 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Po-Chuan Hsieh Cc: "Tobias C. Berner" , Gleb Popov , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" Message-ID: <20240324202715.5d18838d@hal.tijl.coosemans.org> In-Reply-To: References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <2567403.0dHE6SNnxz@angua.firefly> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 24 Mar 2024 00:12:07 +0800 Po-Chuan Hsieh wrote: > On Sat, Mar 23, 2024 at 11:38=E2=80=AFPM Tobias C. Berner > wrote: >> Am Samstag, 23. M=C3=A4rz 2024, 15:14:01 CET schrieb Gleb Popov: =20 >>> On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh =20 >>> wrote: =20 >>>> The branch main has been updated by sunpoet: >>>> >>>> URL: >>>> https://cgit.FreeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d= 803a2b1b8f5f98 >>>> >>>> commit 28472e9722d808739a4d690f6d803a2b1b8f5f98 >>>> Author: Po-Chuan Hsieh >>>> AuthorDate: 2024-03-23 14:01:07 +0000 >>>> Commit: Po-Chuan Hsieh >>>> CommitDate: 2024-03-23 14:01:07 +0000 >>>> >>>> Revert "x11-fonts/noto*: Restructure and update" >>>> >>>> This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8. =20 >>> >>> It is good manners to explain the reason for reverting when doing it. >>> Even better to first talk to the original committer and ask him to the >>> revert. =20 >> >> Moin moin >> >> I completely agree. Given that there has been a phabricator review open >> for two months, with you, sunpoet@ as reviewer, this is looking like poor >> judgement on your side. >> >> As arrowd@ points out, you should have commented on the reverted commit >> first, and elaborate your reasoning for a revert. >> >> Simply reverting the work of others may lead to fewer contributions. >> Please take this into consideration in the future. >> >> >> mfg Tobias =20 >=20 >=20 > Hello, >=20 > I'm sorry that I did not put enough information in this reverting commit > because I need it to be done ASAP so that less users are affected. > There are several reasons I reverted it by myself instead of > requesting tijl@ to do so. > First, I do not use phab review therefore I did not really review the pat= ch > which means it is committed without maintainer approval. > Second, I already have my own work for noto updates which is totally in > different direction with tijl@'s work. I cannot simply rebase my work onto > it. > Third, The problem mentioned in the PR is also handled in my own work. >=20 > Regards, > sunpoet I don't mind getting reverted. I do think Noto is large enough that some thought should go into how we handle it in the ports tree and that you should have put your alternative up for discussion before committing it. Here are some (possible) issues with it that should probably be fixed before the next quarterly: - You are using upstream distfiles that are quite large. The distfiles for the common (Latin, Greek, Cyrillic) fonts Sans, Sans Mono, and Serif add up to 234MB. These fonts will be installed by almost every user that uses FreeBSD as a desktop now that DejaVu appears to have been abandoned. My proposal was to create our own distfiles and I integrated that into makesum so the only extra step compared to a normal version update was to upload the generated distfile to freefall. I was willing to take over maintainership in case you didn't want to deal with that. These distfiles add up to 27MB. And if we put the extra weights (ExtraBold,...) and widths (Condensed,...) in a separate port like you did it would be only 2MB. - Some fonts have been split into x11-fonts/-basic providing Bold, BoldItalic, Italic, and Regular, and x11-fonts/-extra providing additional styles. Only some of these have x11-fonts/ as a metaport currently. This needs to be made consistent. I think it would be best to drop the metaports and move x11-fonts/-basic to x11-fonts/. That way pkg install installs the common styles for all fonts. I think that this would be the most intuitive/convenient. (I was hoping to use subpackages for this instead of extra ports.) - x11/noto-emoji now installs the COLRv1 version of Noto Color Emoji but this isn't supported yet by graphics/cairo so emoji are broken now in gtk applications. I think Ghostscript doesn't support it either. It has to be removed again for now. - Besides Noto Color Emoji there's also the monochrome Noto Emoji that can be useful in print. I think we should let x11-fonts/noto-emoji install the monochrome font and move the existing x11-fonts/noto-emoji to x11-fonts/noto-color-emoji so the names match.