Date: Sun, 29 Jun 2003 06:59:27 +0800 From: "David Xu" <davidxu@freebsd.org> To: "Marcel Moolenaar" <marcel@freebsd.org>, <src-committers@freebsd.org>, <cvs-src@freebsd.org>, <cvs-all@freebsd.org> Subject: Re: cvs commit: src/sys/kern kern_thread.c src/sys/sys kse.h Message-ID: <005501c33dc8$edf33b40$0701a8c0@tiger> References: <200306281945.h5SJjFjF059714@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thank you! ----- Original Message -----=20 From: "Marcel Moolenaar" <marcel@FreeBSD.org> To: <src-committers@FreeBSD.org>; <cvs-src@FreeBSD.org>; = <cvs-all@FreeBSD.org> Sent: Sunday, June 29, 2003 3:45 AM Subject: cvs commit: src/sys/kern kern_thread.c src/sys/sys kse.h > marcel 2003/06/28 12:45:15 PDT >=20 > FreeBSD src repository >=20 > Modified files: > sys/kern kern_thread.c=20 > sys/sys kse.h=20 > Log: > Don't use fuword() and suword() on struct members of type int. This > happens to work on 32-bit platforms as sizeof(long)=3Dsizeof(int), = but > wrecks all kinds of havoc (garbage reads, corrupting writes and > misaligned loads/stores) on 64-bit architectures. > The fix for now is to use fuword32() and suword32() and change the > type of the applicable int fields to int32. This is to make it > explicit that we depend on these fields being 32-bit. We may want > to revisit this later. > =20 > Reviewed by: deischen > =20 > Revision Changes Path > 1.147 +4 -4 src/sys/kern/kern_thread.c > 1.17 +3 -3 src/sys/sys/kse.h >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?005501c33dc8$edf33b40$0701a8c0>