From nobody Mon Feb 2 16:13:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f4Wr852ybz6QgrG for ; Mon, 02 Feb 2026 16:13:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f4Wr83Pq1z3Hxx for ; Mon, 02 Feb 2026 16:13:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770048808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/EHLmjeUAeDJ77snn4hpxwFY/IpVIwgVym98gt14/sg=; b=B0mbibTzNmpYbrr1Uw1tC+QO/V9AefaaT8nwy0yg+VuSiJtMsdqe6PAjRSPvDHV9qxrGKq T4KInOooVHVqhCh7034b/rWqTLLqTcHEu/+zxTIUUyg9hY5HDZbr6SMJnvJCVx8v8lbVBY 0oSCmzuT+HFAIbRb6scIvMdkUfTbtl3ZPiuHV8fmSQaiWHxrIv4qwClDH/nZUhI4CneT93 iOjv8HGKg6nbxFYqx6ZrkE3EmoDLBIA5mOPEQgBey8zSnzEFcx2ZZ0jK/cEhvJNwoSFOfe LgFPyzv/TJAIguNTG23O1zQLHqndoBvpwTgmcreHBSEtKI/xfqqk9GRuCRkiEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770048808; a=rsa-sha256; cv=none; b=ploiH0UxKUe9iw8y46tq4W2a+TnvfZdc6Oj2A2WXivmNH7F9sOiYk8QOgtXN7Cwi1MntIT UmBTF3B+Xga9aEA/L1vksKodxzuuHaLRS5qdFlNS9BwrjH1hJxoZaRRmRR4tT39ThD4Jfy TCGijyNn9LoZJHqDdABKWkvfGtPryfYg5xTsejESFw/azA/H0PFtBD2BJS4qSvfpasW9YX q6L2Cl+soBHuS8n8CXKqXB1eep6288zhY+4e9MnZXf2ZvQoH2qodQfvSJ2lPAcypuAtzMF BrozSWzU5JvVQPMRcgYeFAZNPXs00wXRh+ZGvwrr5kZhr77MaMRVF1jXgkN5rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770048808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/EHLmjeUAeDJ77snn4hpxwFY/IpVIwgVym98gt14/sg=; b=BH7fQ+FvBv0exT9mlnPO90XeRoGGeef7B6DIQkJdnzRb0+9nAuQ8KPVsoR+VEabFF+9G9r LrPJDRDe5eOBUm7fI0WzHASFt/4yAusT+QQuJIkCb9tGy5sisZM62CE17oDzPxM7JcGcJC RduFh0B1p+QJGXS7gzyWGEZ5+SAKX7V/rq0qLds68MaFiDkuLd+b76Q0BD/GIgzUwiinqL qR7UGD0eFbyDRiJZqr5+2c3c/XvGwwUeNCq7xwnph7gF6bL0yCKDvZZ/tPg3Watw/8d7I8 25a/CKGtGwhfkjstinIjV3rMYK1tiedHgySsXArIhATTFObMorn02XYJXXJtzg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f4Wr82yzYzZ7W for ; Mon, 02 Feb 2026 16:13:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19610 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Feb 2026 16:13:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Baptiste Daroussin Subject: git: 0ec58e7c2e53 - main - diff: use pdwait(2) instead of homemade one List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0ec58e7c2e533a15eabfe8dca4a14e9ae93de4b5 Auto-Submitted: auto-generated Date: Mon, 02 Feb 2026 16:13:28 +0000 Message-Id: <6980cd28.19610.2e2a59d0@gitrepo.freebsd.org> The branch main has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=0ec58e7c2e533a15eabfe8dca4a14e9ae93de4b5 commit 0ec58e7c2e533a15eabfe8dca4a14e9ae93de4b5 Author: Baptiste Daroussin AuthorDate: 2026-02-02 15:44:34 +0000 Commit: Baptiste Daroussin CommitDate: 2026-02-02 16:13:16 +0000 diff: use pdwait(2) instead of homemade one MFC After: 3 days Reviewed by: des Differential Revision: https://reviews.freebsd.org/D55053 --- usr.bin/diff/pr.c | 19 ++++++------------- usr.bin/diff/pr.h | 3 +-- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/usr.bin/diff/pr.c b/usr.bin/diff/pr.c index c3ea280073af..f254fbab28b7 100644 --- a/usr.bin/diff/pr.c +++ b/usr.bin/diff/pr.c @@ -28,6 +28,7 @@ #include #include +#include #include #include #include @@ -72,7 +73,7 @@ start_pr(char *file1, char *file2) execl(_PATH_PR, _PATH_PR, "-h", header, (char *)0); _exit(127); default: - + pr->pidfd = pr_pd; /* parent */ if (pfd[1] != STDOUT_FILENO) { pr->ostdout = dup(STDOUT_FILENO); @@ -82,14 +83,6 @@ start_pr(char *file1, char *file2) close(pfd[0]); rewind(stdout); free(header); - pr->kq = kqueue(); - if (pr->kq == -1) - err(2, "kqueue"); - pr->e = xmalloc(sizeof(struct kevent)); - EV_SET(pr->e, pr_pd, EVFILT_PROCDESC, EV_ADD, NOTE_EXIT, 0, - NULL); - if (kevent(pr->kq, pr->e, 1, NULL, 0, NULL) == -1) - err(2, "kevent"); } return (pr); } @@ -109,10 +102,10 @@ stop_pr(struct pr *pr) dup2(pr->ostdout, STDOUT_FILENO); close(pr->ostdout); } - if (kevent(pr->kq, NULL, 0, pr->e, 1, NULL) == -1) - err(2, "kevent"); - wstatus = pr->e[0].data; - close(pr->kq); + while (pdwait(pr->pidfd, &wstatus, WEXITED, NULL, NULL) == -1) { + if (errno != EINTR) + err(2, "pdwait"); + } free(pr); if (WIFEXITED(wstatus) && WEXITSTATUS(wstatus) != 0) errx(2, "pr exited abnormally"); diff --git a/usr.bin/diff/pr.h b/usr.bin/diff/pr.h index 2ff5949f282f..80f20ca7c329 100644 --- a/usr.bin/diff/pr.h +++ b/usr.bin/diff/pr.h @@ -28,8 +28,7 @@ struct pr { int ostdout; - int kq; - struct kevent *e; + int pidfd; }; struct pr *start_pr(char *file1, char *file2);