Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Mar 2012 17:24:37 +0200
From:      Hans Petter Selasky <hselasky@freebsd.org>
To:        Ed Schouten <ed@80386.nl>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r233661 - in head/sys: dev/syscons sys
Message-ID:  <201203291724.37401.hselasky@freebsd.org>
In-Reply-To: <20120329145945.GC36321@hoeg.nl>
References:  <201203291453.q2TErFYE097838@svn.freebsd.org> <20120329145945.GC36321@hoeg.nl>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 29 March 2012 16:59:45 Ed Schouten wrote:
> * Hans Petter Selasky <hselasky@FreeBSD.org>, 20120329 16:53:
> > Modified: head/sys/sys/tty.h
> > =========================================================================
> > ===== --- head/sys/sys/tty.h	Thu Mar 29 13:36:53 2012	(r233660)
> > +++ head/sys/sys/tty.h	Thu Mar 29 14:53:14 2012	(r233661)
> > @@ -197,6 +197,8 @@ void	tty_hiwat_in_block(struct tty *tp);
> > 
> >  void	tty_hiwat_in_unblock(struct tty *tp);
> >  dev_t	tty_udev(struct tty *tp);
> >  #define	tty_opened(tp)		((tp)->t_flags & TF_OPENED)
> > 
> > +/* NULL-safe version of "tty_opened()" */
> > +#define	tty_opened_ns(tp)	((tp) != NULL && tty_opened(tp))
> > 
> >  #define	tty_gone(tp)		((tp)->t_flags & TF_GONE)
> >  #define	tty_softc(tp)		((tp)->t_devswsoftc)
> >  #define	tty_devname(tp)		devtoname((tp)->t_dev)
> 
> Huh? Hm? Hm! :-(
> 
> Please don't make this part of the TTY API. Just add a wrapper to
> syscons.c.

Ok, I'll move the define to syscons.c if no other clients have use for this.

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203291724.37401.hselasky>