From owner-svn-src-all@FreeBSD.ORG Thu Jun 16 18:24:45 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AB51106564A; Thu, 16 Jun 2011 18:24:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 0E7C98FC08; Thu, 16 Jun 2011 18:24:45 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id B519446B03; Thu, 16 Jun 2011 14:24:44 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 51E018A01F; Thu, 16 Jun 2011 14:24:44 -0400 (EDT) From: John Baldwin To: Garrett Cooper Date: Thu, 16 Jun 2011 14:24:43 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201106161535.p5GFZCb7034904@svn.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106161424.43811.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 16 Jun 2011 14:24:44 -0400 (EDT) Cc: Tai-hwa Liang , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh Subject: Re: svn commit: r223151 - head/lib/libstand X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2011 18:24:45 -0000 On Thursday, June 16, 2011 1:40:36 pm Garrett Cooper wrote: > On Thu, Jun 16, 2011 at 8:53 AM, Warner Losh wrote: > > > > On Jun 16, 2011, at 9:35 AM, Tai-hwa Liang wrote: > > > >> Author: avatar > >> Date: Thu Jun 16 15:35:12 2011 > >> New Revision: 223151 > >> URL: http://svn.freebsd.org/changeset/base/223151 > >> > >> Log: > >> Using the correct format string(%zu) for size_t type. This should fix 64 > >> bits builds. > >> > >> Submitted by: Garrett Cooper > > > > How about we hold all fixes until it *ACTUALLY* builds on all universe platforms? > > > > I hate to be cranky, but build breakage costs a lot of time. And for stupid stuff like this? I'm inclined to force WARNS=0 until people can actually fix it right. > > This was stupid breakage on my part for not running this through > universe first. The patch that builds upon this that I submitted in > the other thread so far _does_ unbreak universe on ia64 and mips*. > Still working on getting it to pass through amd64, i386, and sparc64 > at least, which is going to be a few more hours because for some magic > reason make -j doesn't work for me with universe. You probably want to do 'make JFLAG=-j6 tinderbox' rather than 'make -j6 tinderbox'. -- John Baldwin