From owner-freebsd-bugs@FreeBSD.ORG  Wed Jun  2 19:10:03 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0167B1065676
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  2 Jun 2010 19:10:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B9B908FC12
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  2 Jun 2010 19:10:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o52JA2XK030910
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 2 Jun 2010 19:10:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o52JA2Sk030909;
	Wed, 2 Jun 2010 19:10:02 GMT (envelope-from gnats)
Resent-Date: Wed, 2 Jun 2010 19:10:02 GMT
Resent-Message-Id: <201006021910.o52JA2Sk030909@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	CyberLeo <cyberleo@cyberleo.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5018C1065677
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed,  2 Jun 2010 19:01:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 401D48FC1C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed,  2 Jun 2010 19:01:37 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o52J1adg004021
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 Jun 2010 19:01:36 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o52J1aJA004020;
	Wed, 2 Jun 2010 19:01:36 GMT (envelope-from nobody)
Message-Id: <201006021901.o52J1aJA004020@www.freebsd.org>
Date: Wed, 2 Jun 2010 19:01:36 GMT
From: CyberLeo <cyberleo@cyberleo.net>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/147337: agp_nvidia device_printf missing newline
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jun 2010 19:10:03 -0000


>Number:         147337
>Category:       kern
>Synopsis:       agp_nvidia device_printf missing newline
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 02 19:10:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     CyberLeo
>Release:        8.1-BETA1
>Organization:
CyberLeo.Net
>Environment:
>Description:
A device_printf call in agp_nvidia.c is missing a terminating newline in its format string.
>How-To-Repeat:

>Fix:
Attached patch

Patch attached with submission follows:

--- sys/dev/agp/agp_nvidia.c	2010-03-07 05:40:17.000000000 -0600
+++ sys/dev/agp/agp_nvidia.c	2010-03-07 05:40:55.000000000 -0600
@@ -282,7 +282,7 @@
 	case 14: return (64 * 1024 * 1024); break;
 	case 15: return (32 * 1024 * 1024); break;
 	default:
-		device_printf(dev, "Invalid aperture setting 0x%x",
+		device_printf(dev, "Invalid aperture setting 0x%x\n",
 		    pci_read_config(dev, AGP_NVIDIA_0_APSIZE, 1));
 		return 0;
 	}


>Release-Note:
>Audit-Trail:
>Unformatted: