From owner-svn-src-head@FreeBSD.ORG Fri Sep 14 14:43:14 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CD73106566C; Fri, 14 Sep 2012 14:43:14 +0000 (UTC) (envelope-from gber@freebsd.org) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id 0DB998FC14; Fri, 14 Sep 2012 14:43:13 +0000 (UTC) Received: from localhost (unknown [213.17.239.109]) by smtp.semihalf.com (Postfix) with ESMTP id CD764119C09; Fri, 14 Sep 2012 16:43:06 +0200 (CEST) X-Virus-Scanned: by amavisd-new at semihalf.com Received: from smtp.semihalf.com ([213.17.239.109]) by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new, port 10024) with ESMTP id aK8Cj+YKCE+Y; Fri, 14 Sep 2012 16:43:06 +0200 (CEST) Received: from [10.0.0.93] (cardhu.semihalf.com [213.17.239.108]) by smtp.semihalf.com (Postfix) with ESMTPSA id 3C58D119C00; Fri, 14 Sep 2012 16:43:06 +0200 (CEST) Message-ID: <50535E29.2030102@freebsd.org> Date: Fri, 14 Sep 2012 18:41:13 +0200 From: Grzegorz Bernacki User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.24) Gecko/20120127 Thunderbird/3.1.16 MIME-Version: 1.0 To: Aleksandr Rybalko References: <201209140933.q8E9XZnd088621@svn.freebsd.org> <20120914171652.780e25c6.ray@freebsd.org> In-Reply-To: <20120914171652.780e25c6.ray@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240484 - head/sys/dev/fdt X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2012 14:43:14 -0000 On 09/14/12 16:16, Aleksandr Rybalko wrote: > On Fri, 14 Sep 2012 09:33:35 +0000 (UTC) > Grzegorz Bernacki wrote: > >> Author: gber >> Date: Fri Sep 14 09:33:35 2012 >> New Revision: 240484 >> URL: http://svn.freebsd.org/changeset/base/240484 >> >> Log: >> Set busaddr and bussize to 0 when fdt_get_range() fails. > > Why bussize is 0? I though that setting it to 0 makes sense, since we do not use this variable in this function and setting it to some value could be confused. I could skip setting it, but I also thought it could cause confusion :). If you think that setting it to other value or remove it will be better please let me know and I will change it. thanks grzesiek