Date: Fri, 14 Sep 2012 18:41:13 +0200 From: Grzegorz Bernacki <gber@freebsd.org> To: Aleksandr Rybalko <ray@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240484 - head/sys/dev/fdt Message-ID: <50535E29.2030102@freebsd.org> In-Reply-To: <20120914171652.780e25c6.ray@freebsd.org> References: <201209140933.q8E9XZnd088621@svn.freebsd.org> <20120914171652.780e25c6.ray@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/14/12 16:16, Aleksandr Rybalko wrote: > On Fri, 14 Sep 2012 09:33:35 +0000 (UTC) > Grzegorz Bernacki<gber@FreeBSD.org> wrote: > >> Author: gber >> Date: Fri Sep 14 09:33:35 2012 >> New Revision: 240484 >> URL: http://svn.freebsd.org/changeset/base/240484 >> >> Log: >> Set busaddr and bussize to 0 when fdt_get_range() fails. > > Why bussize is 0? I though that setting it to 0 makes sense, since we do not use this variable in this function and setting it to some value could be confused. I could skip setting it, but I also thought it could cause confusion :). If you think that setting it to other value or remove it will be better please let me know and I will change it. thanks grzesiek
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50535E29.2030102>