From owner-freebsd-rc@FreeBSD.ORG Fri Dec 9 19:38:35 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F9F016A41F; Fri, 9 Dec 2005 19:38:35 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 286B443D7D; Fri, 9 Dec 2005 19:38:31 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id jB9JcVld019185; Fri, 9 Dec 2005 11:38:31 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id jB9JcUhA019184; Fri, 9 Dec 2005 11:38:30 -0800 Date: Fri, 9 Dec 2005 11:38:30 -0800 From: Brooks Davis To: Doug Barton Message-ID: <20051209193830.GA15097@odin.ac.hmc.edu> References: <4398AB6A.3000209@FreeBSD.org> <20051208222013.GB5759@odin.ac.hmc.edu> <43996043.8020609@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline In-Reply-To: <43996043.8020609@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@FreeBSD.org Subject: Re: For Review: Latest update to rcorder patch X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2005 19:38:35 -0000 --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 09, 2005 at 02:45:23AM -0800, Doug Barton wrote: > Brooks Davis wrote: >=20 > >Conceptually, I'm happy with this. A few things. > > > > - I'd suggest explicitly stating that the only sane values > > for $early_late_divider are probably root, mountcritlocal, and > > mountcritremote. >=20 > Yeah, I ended up having to finish my message in a hurry (real life > called), and I forgot to add that I hadn't finished the rc.conf > man page entry yet. I am always hesitant to add too much info to > the rc.conf file, mostly because people who are determined to self > foot-shoot will ignore it anyway. :) That's fair. :) > I've added my proposed patch to rc.conf(5). Instead of talking about diskless systems I'd talk about having remote file systems in ${local_startup} such as if /usr were an nfs mount. The reason for this suggestion is that this and not being diskless are what makes the difference. All my diskless systems could actually have early_late_divider=3Droot since the roots contain everything in a chroot to allow them to be out of sync with the OS of the build system. You could also do something old school and have the base system on the local disk and have all packages be shared. That's certainly still popular in some places with lots of workstations. > > - diskless.8 should probably be updated to mentation that > > early_late_divider must be set to mountcritremote for the documented > > configuration to work. >=20 > I can do that as part of the change if you want, or you can do it, just l= et > me know. Please go ahead. diskless.8 annoys me because I don't like its suggested design. I really need to get around to doing a writeup on how I like to do diskless stuff. Probably after I work up a modified nanobsd build to handle it (in process for an upgrade from 4.10 to 6.0 on my cluster). > > - If you want to depend on an rc.conf value in /etc/rc, > > /etc/rc.d/rcconf.sh should die. early_late_divider is only non-zero > > every time through the loop by accident at this point.=20 >=20 > Ok, good plan. :) Based on our earlier conversation, I've also moved the > sourcing of rc.subr to after rc.initdiskless. In the non-diskless case,= =20 > this > should be a total noop, so I'm not worried about this part of the change, > and if we're going to do it, we should do it now. Although I didn't inclu= de > it in this patch, I'll remove rcconf.sh as well. OK. I might make rcconf.sh into a no-op that provides rcconf in the first commit and remove it for real in a day or so to make it easier to debug any inadvertent issues that result from increasing the number of scripts with no dependencies. > >Since > > rcconf.sh is no longer needed due to moving rc.d/initdiskless back > > to /etc/rc.initdiskless, it's safe to handle configuration in /etc/rc. >=20 > Sounds great to me! >=20 > Thanks as always for your feedback and careful thought here. You're welcome. I'm glad to see this is being done. Despite the increase in complexity in /etc/rc, I think we're well on our way to a more sane and comprehensible startup process. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDmd00XY6L6fI4GtQRAoBkAKCJVPc6A6s85OrZZN8py1g6TGc+pwCdHo6X IJVOckMc6R6pAKJhoAhkXwg= =d6rC -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--