From nobody Thu Jul 10 12:27:36 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bdDd62t0Lz610Qr; Thu, 10 Jul 2025 12:27:38 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bdDd622ZHz3Qj2; Thu, 10 Jul 2025 12:27:38 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752150458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yMRVUrLADzAa168uFTk5QuYr+zdTM2bolCIvpYYN5ys=; b=GCxI2g7h/LxHKKWcnaXoh9Mb4NQ0xdB0kIUldE4xCrpWZOLzSpZrUCq4v/QhsmwyBEiULS bw0jt5g2gzRcy3fbmi08y8S1LNfwhk+7sGB6DW8bGbOV+VaNduo9dKI+kep2xnrtwf2ZA1 XgyXFxQxvlbZQte0HHpe/A9FdEBqz7qobrVZRDufVFM73GsULnbTaLLQzj0fPIRB3+vGhr iRv8zO74LSX6PQJhz/qOXhlDNC/yXdHCmXwkzp9t5Xtz8xCTmlvRyYhR8GF5IOXgh2ztE8 3gkVmQhiWVC3DkaBhVhRVej1aer3WV9Tp7rOj71Xbffh7G718BWwF3wU5zGYkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752150458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yMRVUrLADzAa168uFTk5QuYr+zdTM2bolCIvpYYN5ys=; b=b+3PeVPuPmqhMdHY3W1cya6nZe0+fwHKgsffezR55h9V+12QddjS4pEz7v9FcjZlXN+fhv Ljn7pkeF4ZCzgrotpTmZ8EWN5NRPJAdxG7LnUgTOprYAvfDEJ50vrPG4/T1egtgYi0ck2v 2Qrhs44rUkCIq0MJOBWG8kbiFp4SCpF6SX4vxjNgKCcuh+kUX/B7W1ww4138rig/fXBjea xO2M+NbRqcqu/vTGzPgP9biXl7nvFmp1ZYT6iC7yc/Kw1f/4Np4TXSih03jfJNQmklh8qb GO1/mJbMXoM7GV5xvKfOM9BbrI97UiuUeI0wxImec1Fi2gEAEe50XPU7U/GZfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752150458; a=rsa-sha256; cv=none; b=BYrYxDPlVGh+js08SOzvrgy8AnrI6UYSYoUgVM5xMHaB2ZHjqm3mLQu2AE3hQ3gnxEqMMf L88UPxSKt2yncBifRGapFfcR8oEORqnYvspr9gsmxgyFgJbbtJxfTZj6w9PqBBDd6ALgLj xWf+3z73O5P+IaelqyKSO2aQew9PIRzXP5WahZd+clqk9/wH062+nph+3oGsZQoZa+X2b3 KSg8hDnYV+xhQI1z3skkWVfAEBSvIAaRO7ADJiOE5E0b5RT5ONcBr5otD8t6b4PwvpcMTF jLtTnTDKFy77M4Fgxlh0zdU3IBRs4EANZb0tl6Sedj96/5BiBwHI+x6Zw4BYRA== Received: from ltc.des.dev (unknown [IPv6:2a01:e0a:c54:bed0:922e:16ff:fef1:acef]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bdDd614Zrzltj; Thu, 10 Jul 2025 12:27:38 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id DE295704AA; Thu, 10 Jul 2025 14:27:36 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Rick Macklem Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: c5d72d29fe0e - main - nfsv4: Add support for the NFSv4 hidden and system attributes In-Reply-To: <202507062254.566MsbnL090918@gitrepo.freebsd.org> (Rick Macklem's message of "Sun, 6 Jul 2025 22:54:37 GMT") References: <202507062254.566MsbnL090918@gitrepo.freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 10 Jul 2025 14:27:36 +0200 Message-ID: <867c0gcjt3.fsf@ltc.des.dev> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rick Macklem writes: > diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvnop= s.c > index 0049d7edca33..fbfcdafaa06b 100644 > --- a/sys/fs/nfsclient/nfs_clvnops.c > +++ b/sys/fs/nfsclient/nfs_clvnops.c > [...] > @@ -1092,7 +1100,8 @@ nfs_setattr(struct vop_setattr_args *ap) > vap->va_gid !=3D (gid_t)VNOVAL || vap->va_atime.tv_sec !=3D VNOVAL = || > vap->va_mtime.tv_sec !=3D VNOVAL || > vap->va_birthtime.tv_sec !=3D VNOVAL || > - vap->va_mode !=3D (mode_t)VNOVAL) && > + vap->va_mode !=3D (mode_t)VNOVAL || > + vap->va_flags !=3D (u_long)VNOVAL) && > (vp->v_mount->mnt_flag & MNT_RDONLY)) > return (EROFS); > if (vap->va_size !=3D VNOVAL) { vap->va_flags was already checked (in the line just before the first line of context), albeit without a cast. Coverity erroneously claims that this causes the entire expression to always be true, because it thinks VNOVAL and (u_long)VNOVAL are two different values. That's not the case, but you probably still want this: diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvnops.c index fbfcdafaa06b..fa451887e73e 100644 --- a/sys/fs/nfsclient/nfs_clvnops.c +++ b/sys/fs/nfsclient/nfs_clvnops.c @@ -1096,12 +1096,11 @@ nfs_setattr(struct vop_setattr_args *ap) /* * Disallow write attempts if the filesystem is mounted read-only. */ - if ((vap->va_flags !=3D VNOVAL || vap->va_uid !=3D (uid_t)VNOVAL || + if ((vap->va_flags !=3D (u_long)VNOVAL || vap->va_uid !=3D (uid_t)VNOVAL = || vap->va_gid !=3D (gid_t)VNOVAL || vap->va_atime.tv_sec !=3D VNOVAL || vap->va_mtime.tv_sec !=3D VNOVAL || vap->va_birthtime.tv_sec !=3D VNOVAL || - vap->va_mode !=3D (mode_t)VNOVAL || - vap->va_flags !=3D (u_long)VNOVAL) && + vap->va_mode !=3D (mode_t)VNOVAL) && (vp->v_mount->mnt_flag & MNT_RDONLY)) return (EROFS); if (vap->va_size !=3D VNOVAL) { DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org