Date: Sat, 02 Jun 2012 03:43:49 +0900 (JST) From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: jkim@FreeBSD.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236414 - in head/sys: amd64/acpica i386/acpica Message-ID: <20120602.034349.112976915.iwasaki@jp.FreeBSD.org> In-Reply-To: <201206011818.q51IImh5035315@svn.freebsd.org> References: <201206011818.q51IImh5035315@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, thanks for following up.
> Log:
> Call AcpiSetFirmwareWakingVector() with interrupt disabled for consistency.
Are you sure about this? Original code is like this (interrupt ENABLED);
----
intr_restore(rf);
AcpiSetFirmwareWakingVector(0);
if (ret == 0 && mem_range_softc.mr_op != NULL &&
----
Regarding to ACPICA source code, they said nothing about this
so I think it's not big deal.
Just FYI, AcpiSetFirmwareWakingVector(0) was called with interrupt
enabled in Linux.
Thanks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120602.034349.112976915.iwasaki>