From owner-svn-src-head@FreeBSD.ORG  Fri Jun  1 18:43:57 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9B99C106566B;
	Fri,  1 Jun 2012 18:43:57 +0000 (UTC)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from locore.org (ns01.locore.org [218.45.21.227])
	by mx1.freebsd.org (Postfix) with ESMTP id 341878FC18;
	Fri,  1 Jun 2012 18:43:56 +0000 (UTC)
Received: from localhost (celeron.v4.locore.org [192.168.0.10])
	by locore.org (8.14.5/8.14.5/iwasaki) with ESMTP/inet id q51IhnIu021661;
	Sat, 2 Jun 2012 03:43:49 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Date: Sat, 02 Jun 2012 03:43:49 +0900 (JST)
Message-Id: <20120602.034349.112976915.iwasaki@jp.FreeBSD.org>
To: jkim@FreeBSD.org
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
In-Reply-To: <201206011818.q51IImh5035315@svn.freebsd.org>
References: <201206011818.q51IImh5035315@svn.freebsd.org>
X-Mailer: Mew version 3.3 on Emacs 20.7 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r236414 - in head/sys: amd64/acpica i386/acpica
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2012 18:43:57 -0000

Hi, thanks for following up.

> Log:
>   Call AcpiSetFirmwareWakingVector() with interrupt disabled for consistency.

Are you sure about this?  Original code is like this (interrupt ENABLED);

----
        intr_restore(rf);
 
        AcpiSetFirmwareWakingVector(0);

        if (ret == 0 && mem_range_softc.mr_op != NULL &&
----

Regarding to ACPICA source code, they said nothing about this
so I think it's not big deal.

Just FYI, AcpiSetFirmwareWakingVector(0) was called with interrupt
enabled in Linux.

Thanks