From nobody Tue Aug 4 19:33:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hF3d05SMNz6nJP8 for ; Tue, 04 Aug 2026 19:33:56 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hF3cy6K00z3M2n for ; Tue, 04 Aug 2026 19:33:54 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); arc=pass ("google.com:s=arc-20260327:i=1"); spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=asomers@gmail.com Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-6a14f118a46so229491a12.2 for ; Tue, 04 Aug 2026 12:33:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1785872033; cv=none; d=google.com; s=arc-20260327; b=FC26N1axRtyaV7U+/Td9jQY3SBY3BsGVQqjN/arVIyJHXNYzkfdciGXcNN6xPw1Xuf pwGC528bAn4JkvvGpHRUhCGzFXDmBThNYaYXwIhNt8Y0jcSed7oQThKAg4Qk5sO+aXP+ KuW+q7GqiBiSsyR/FH1+Z9rXBroqUw5Y/MCqEUviQAcQ1TofjPenQhvgUCijOFHM5UZj pnDNh8+LPVWrsTSxsu165zqNO9iKckhmSwycVerrQ7bXIP4VQPqCLY/gLMhHCqGyiu8u zvvPxizhzfbdng85BXs0NEqYPz0RMIeDU3np6eGC65Cs5WzmJV07+9gspryxPqXT2gA9 B9RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:subject:message-id:date:from :in-reply-to:references:mime-version; bh=ygcJFRDATa8NmowdrIsvOPWr49okIdgWsrsFO8Wc27o=; fh=OgnIhueV6/X1y7VHT4vQ7xlAzd4OBV2QgP71nD/Wu+c=; b=Cacda+MoPbn1J1tGFo51MZc9tTFJrLIekMCcOFT6AYNLFlpztL3Nh2hV8fdR9Cgw/8 1QRig+WwP0ZU0rLO4iWmdX1SlHp3Oe+WU4LZ25/65t03AyVdaWPhRfH3YTwSFVXLoY3l hi3Cy2NlkwPMYLrT8vg93SLffEx1V+9BmQjp+TwRtvH89pripaVE0qbZFlOaQYFzcDR/ zRLjgAUUyOtxscdFmqpMHBrJF+AHdpatz3MaObsulLHMhjTk1uJKwDuPa2UQ7vRbyyJ3 EV1CB7MQouPEpCV8C6GjV2xwnmwq8StAoAUgKJnvgOMTv1QqWye1BjJa4kdmI371G/j4 lPXw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785872033; x=1786476833; h=content-transfer-encoding:content-type:cc:subject:message-id:date :from:in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=ygcJFRDATa8NmowdrIsvOPWr49okIdgWsrsFO8Wc27o=; b=Oy5LnoGPuisXBZCbQcL1Dk3cqFaM7tABAefouenUI2bOUkjaFMqj2nOGt4E0LZlfvH Ik1ymw/PNpxc9X5OLfeBan86Jk5RCkR0TZ2/5A1Y2oSCSdQNiggT4fjOgC2PQ1Jt1h4W 1+8dpGdVFNPqgd6TbcSztVpikfXasURxgBf+OPNAyrANoyINoCgBCa5KR67+Szl2UC01 +t8c/iCMnoJbt1Ovj9S7iAAas5lnva9VU5pcPWvTqy1vAjbznJj5F8fb8qCvHTXSWVx+ ZStbb7gY/4nPa8sC1iQ16HHnLF/dTyb6qyHZgOabOMgkNJhZxl27NukkU0npcDkOTcaW mVoA== X-Forwarded-Encrypted: i=1; AHgh+Rq/LdwYO7bgF5YmdgVIrq5unsfSoiga0hASntZltsd86yDNYTyVACLx7UWJrzeWvmhm4DqJ4wW4E0a7a8p8V/MiYwtJ@freebsd.org X-Gm-Message-State: AOJu0YwIs76gk24Lw8srITtg8/A0RoSuJQeIe+8peqeE17F6lrAycOkK 4DpYXlXXkrUY1F/dfshkFMDmVjzCo8rtri+Dsv7yOkbyMIlL4NPzLkzLBuSlDpd31n++Oiuclah axd9D4Ig+az4guTOmTQZEZ0TtMSUjHFlsjStq X-Gm-Gg: AR+sD11HKw3zLWqT3zD2HbL4ZDEBCnqvXn8x3bHQjJnu/++4C4/KHM86lkqhrClxwZy HxP/qrr+2FShhrLV4GQ25+QvxA26l5wehuIfsIDhbsywidugGRSYjwu+DycNWDnUkryv849pX5D e3mmWjeYKkwOrFYWagR3sui6VrGli/bAIKcsBmZITaFbeeMmeEV/lfIrDdANEd+8Sf3qG56X728 u0QHDSgcKlyRrHSRZ8Z9Zsw/5iDneSfrHl732MXv/07OuTJRW+nPPPGQ7TRfrvpizrs2uuiIjLf 19WtiICM9pNHtQsLgnvHZf3UxuFM3BXTW543shXNPNAKfQlYqNfKTfBCBrPHDf5NCWZvB2Y5S8l OQyChk75T9+3v57TC/RYSyUnun1vO4A== X-Received: by 2002:a05:6402:548a:b0:69c:72e2:a3d5 with SMTP id 4fb4d7f45d1cf-6a14f0a7b45mt731159a12.6.1785872032992; Tue, 04 Aug 2026 12:33:52 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a70e844.251cb.6995429f@gitrepo.freebsd.org> In-Reply-To: From: Alan Somers Date: Tue, 4 Aug 2026 13:33:40 -0600 X-Gm-Features: AUfX_myq14XJUxvhbmHGkCK_1ut80kLBZNF_wnamdTk6gpl-WbNtcXiow81yW90 Message-ID: Subject: Re: git: 4bd01d6ae016 - main - fts: refactor to use fd-relative operations internally Cc: Mark Johnston , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-1.73 / 15.00]; MISSING_TO(2.00)[]; ARC_ALLOW(-1.00)[google.com:s=arc-20260327:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.83)[-0.833]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; FREEFALL_USER(0.00)[asomers]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.46:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; RCVD_COUNT_ONE(0.00)[1]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.46:from]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4hF3cy6K00z3M2n X-Spamd-Bar: - Try this patch. It works for me. I don't have an ATF regression test to go with it, though: diff --git a/lib/libc/gen/fts.c b/lib/libc/gen/fts.c index 204340e4b87f..3dd9b6432a2c 100644 --- a/lib/libc/gen/fts.c +++ b/lib/libc/gen/fts.c @@ -489,8 +489,7 @@ fts_read(FTS *sp) * FTS_STOP or the fts_info field of the node. */ if (sp->fts_child !=3D NULL) { - if (fts_safe_changedir(sp, p, - p->fts_dirfd, p->fts_name)) { + if (fts_safe_changedir(sp, p, -1, p->fts_name)) { p->fts_errno =3D errno; p->fts_flags |=3D FTS_DONTCHDIR; for (p =3D sp->fts_child; p !=3D NULL; On Tue, Aug 4, 2026 at 1:00=E2=80=AFPM Alan Somers wr= ote: > > On Tue, Aug 4, 2026 at 12:58=E2=80=AFPM Mark Johnston = wrote: > > > > On Mon, Aug 03, 2026 at 07:13:08PM +0000, Alan Somers wrote: > > > The branch main has been updated by asomers: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D4bd01d6ae01632501b6343= 8b8d9a401db9744a78 > > > > > > commit 4bd01d6ae01632501b63438b8d9a401db9744a78 > > > Author: Jitendra Bhati > > > AuthorDate: 2026-06-12 17:07:55 +0000 > > > Commit: Alan Somers > > > CommitDate: 2026-08-03 19:12:28 +0000 > > > > > > fts: refactor to use fd-relative operations internally > > > > > > Replace all _open() calls with _openat() in __fts_open(), fts_rea= d(), > > > and fts_children(). Replace statfs() with _fstatfs(). > > > > > > Add fts_dirfd to struct _ftsent, set to the file descriptor of th= e > > > parent directory. Callers can use openat(ent->fts_dirfd, ent->fts= _name, > > > ...) to access files safely without relying on fts_accpath, which > > > enables programs in capability mode to open the files described b= y > > > _ftsent. > > > > > > This is a preparatory change for fts_openat() which will allow ca= llers > > > to provide a pre-opened directory fd, enabling fts(3) traversal i= nside > > > Capsicum capability mode. > > > > > > Mirror all fts_open() changes to fts_open_b(). > > > > > > As a result of expanding _ftsend, publish new ELF symbol versions= for > > > fts_openat and related functions. > > > > > > Sponsored by: Google LLC (GSoC 2026) > > > Reviewed by: asomers > > > Pull Request: https://github.com/freebsd/freebsd-src/pull/2303 > > > > Quite a few regression tests seem to be failing after this commit, e.g.= , > > some of the makefs tests: https://ci.freebsd.org/job/FreeBSD-main-amd64= -test/29201/ > > I'm testing a fix now. I should have something ready for you soon.