From owner-cvs-all@FreeBSD.ORG  Tue Mar 27 17:50:12 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6211B16A401;
	Tue, 27 Mar 2007 17:50:12 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 4DBB813C4B7;
	Tue, 27 Mar 2007 17:50:12 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196])
	by elvis.mu.org (Postfix) with ESMTP id 1B0BF1A3C19;
	Tue, 27 Mar 2007 10:50:12 -0700 (PDT)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 87B2251389; Tue, 27 Mar 2007 13:50:11 -0400 (EDT)
Date: Tue, 27 Mar 2007 13:50:11 -0400
From: Kris Kennaway <kris@obsecurity.org>
To: Marcel Moolenaar <xcllnt@mac.com>
Message-ID: <20070327175011.GA82191@xor.obsecurity.org>
References: <200703270529.l2R5TfVk087238@repoman.freebsd.org>
	<20070327074334.GA52121@xor.obsecurity.org>
	<2EA36547-0EB1-47B0-8F07-D394394CF3BD@mac.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2EA36547-0EB1-47B0-8F07-D394394CF3BD@mac.com>
User-Agent: Mutt/1.4.2.2i
Cc: cvs-src@FreeBSD.org, Marcel Moolenaar <marcel@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Kris Kennaway <kris@obsecurity.org>
Subject: Re: cvs commit: src/sys/kern vfs_subr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Mar 2007 17:50:12 -0000

On Tue, Mar 27, 2007 at 09:36:56AM -0700, Marcel Moolenaar wrote:
> 
> On Mar 27, 2007, at 12:43 AM, Kris Kennaway wrote:
> 
> >On Tue, Mar 27, 2007 at 05:29:41AM +0000, Marcel Moolenaar wrote:
> >>marcel      2007-03-27 05:29:41 UTC
> >>
> >>  FreeBSD src repository
> >>
> >>  Modified files:
> >>    sys/kern             vfs_subr.c
> >>  Log:
> >>  PowerPC is the only architecture with mpsafe_vfs=0. This is now
> >>  broken. Rudimentary tests show that PowerPC can run with
> >>  mpsafe_vfs=1. Make it so...
> >
> >If this is the vget panic via soft updates then a fix is pending for
> >that.  Nevertheless mpsafevfs=1 is a good thing :)
> 
> Maybe. I don't have the backtrace handy. It had to do with S/U, so it
> probably is then. I didn't see it on my amd64 box, so I assumed it was
> specific to PowerPC. Setting mpsave_vfs=1 solved it for me (or
> should I say avoided it for me? :-) I figured it's better to hunt down
> bugs in the mpsafe_vfs=1 case then it is in the mpsafe_vfs=0 case.
> This is not to say that mpsafe_vfs=0 can be broken, but rather that
> I prefer to work on improving the mpsafe_vfs=1 case...

I agree that this is preferable.

thanks,
Kris