From nobody Fri Sep 9 07:03:06 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MP6QP0zCwz4bx87; Fri, 9 Sep 2022 07:03:09 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MP6QP0VYFz3D5Z; Fri, 9 Sep 2022 07:03:09 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662706989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z+WQzF386z5NJp0EBK+eBMgP2xecur0qcC6k5RW4X94=; b=yFZdXgqg1Ti1UWeNBHD+YJ6gmlrshihAIJ/zm5TTvcXu7/GasV8djeTKnSYnMoqfTGtdE4 XCY29hq5Z3cWzylZfXbTg356P+QdEUzj5qDNFAeJvYPJ+uquZHvQcaO97l+AtNjgylF1Yt XhXNREoZTV94u1PibP3gr0d2Wjfyp00KCyaAtybLwRr2ryeD3dZpexS4pAIHjGSGuCVJLe iO0DxY73H6FHpZ798hGH3eXBbcNQ07Y1OvNmBVHaxdryhyZpREpvpVKh+RAx1xkH4u86w4 NonB2ViM0YDkupc+bv0lMIEvL8mIHcQ8DCYy/hum2JrVzh42w6mCbEW7Em61SA== Received: from localhost (p5b29d0b7.dip0.t-ipconnect.de [91.41.208.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MP6QN41FYz1CW3; Fri, 9 Sep 2022 07:03:08 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Fri, 9 Sep 2022 09:03:06 +0200 From: Gordon Bergling To: Ed Maste Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f0d4c2afd65f - main - pmc(3): Correct some typos in event descriptions Message-ID: References: <202209041052.284Aqvu2007702@gitrepo.freebsd.org> <05b97d9c-ff1d-0da2-ee22-0c054e853a77@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Arg+ym/KN0kWx7DB" Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 13.1-STABLE amd64 X-Host-Uptime: 8:56AM up 2 days, 15:47, 4 users, load averages: 0.68, 0.63, 0.53 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662706989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z+WQzF386z5NJp0EBK+eBMgP2xecur0qcC6k5RW4X94=; b=kxE3Dz7bcb81WghwbN5NGxxdPlGmFghUT6fIW4ncxrf7BnMXTNFk35D5xx3vsRbPtRIIjU kS/wzsAoWeqtK+Y4zghagXukDrbZZFl8DttfZgKqukZyuqk9Dvzw4eVJIw4zFFyN2/FH9C PIjTJcNSHbck3z4Pv4H7FDeZQCbgX6dFx+pn8qlmQS0BmfKZZQJisW6s+RLYt794pJV8Kc fQgCTuco0OZzcnFNvioztDzIsOFZMTTub0A3rNVRICugv45JfabtrLzKzGb0Jppfd4iG95 v7YAs6iOYjGW5Aqkdnl8WgozHYFhi2Pjjc+P54XOOeXAqlnayQ3jHhAPB04JJA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662706989; a=rsa-sha256; cv=none; b=bUYNQii+MseV1OJtYi0l/vVCRdBnOHlRA1RuFPjoeKvQCEnngyxGYNd42eUKXXyJnp/dpJ itWIib0xCpn7FgKjkgO6o7Wmk7b7pvNDo1xsBwxNaxcmoc4Zkg9HNZyMnNuuHv6RIfKOuh oyCGUzeSifplX+ADdrsol1NoOEk9hOEXv3URc9x6pCjZNsnMmdkjJ7cRUj6YzpZQsYhDT1 xWfDH0NfCTWIBWdG7o1QhdCVtBxauUkunkRuyPNGHFV0sl+LBwxDPyvk78PGGLf/k/u4NI CFA3rc+Lttt7Ngj1ITcNbB/R3YtjyDezG6qCTCP8SV7gDXzlWCByVqvaYAEMog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --Arg+ym/KN0kWx7DB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 08, 2022 at 09:32:32AM -0400, Ed Maste wrote: > On Wed, 7 Sept 2022 at 13:41, John Baldwin wrote: > > > --- > > > lib/libpmc/pmu-events/arch/x86/broadwell/pipeline.json | 4 += +-- > > > lib/libpmc/pmu-events/arch/x86/broadwellde/pipeline.json | 4 += +-- > > > lib/libpmc/pmu-events/arch/x86/broadwellx/pipeline.json | 4 += +-- > > > lib/libpmc/pmu-events/arch/x86/cascadelakex/uncore-other.json | 2 +- > > > lib/libpmc/pmu-events/arch/x86/silvermont/pipeline.json | 4 += +-- > > > lib/libpmc/pmu-events/arch/x86/skylakex/uncore-other.json | 2 +- > > > > I think these files are actually 3rd party (and should really be under > > contrib/ in that case?) so probably shouldn't be changed. Maybe you can > > send the changes upstream to Linux instead? >=20 > Yes, these come from Linux and the fixes should be sent there. The > process is a bit cumbersome but at least well documented; I've done it > for a couple of pmu-events files before, e.g. > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=3D= 28396b7df09b9565f404591c9945eac43526cb3f >=20 > The process is documented in the Linux source tree at > Documentation/process/submitting-patches.rst I wasn't aware that those event files come from Linux. I will submit the fi= xes upstream. If I remember correctly I have done some more spelling fixes, so I diff the whole directory against recent Linux sources. About the move to contrib, I could do that, but before I invest work in that direction, a decision should be made before that. --Gordon --Arg+ym/KN0kWx7DB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmMa5ShfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYx QjU4OEQwQTYzOTVGQkM4N0ZDNUNCODM5MDVGNjU3Q0FDRkQzREMACgkQOQX2V8rP 09ycGgf/b0bkQ++kL3diM5RH/+l4/WAKE81PkUxdMeN8FN/MRwE4pqfNzNp1yreq 5h2OM5nzAhgbzpMoCTbw2rf5qkxuAReIMZQW5IwT89vsElYiOhP9gqHgzH+Unnka kKLeU4espv6IkOqjBSXSmFkD5/xl/un2EUqtfxituKqwyeAFvmrKqinnY+zc9nkg r0+mOeQI42JGk/SO6VhS2WD1hqNMdjyDNdjljtwKeHXt867Ko+SvPPvXgw4NByi9 DiMxxYR6zRsVXJA7k5CZSJ6L8RUM5LJHvbx2L8QATP+ZjgyXCraNkL1Cw86kvx+4 t/yZmSHWghinSHgjn6RFqmmaAE2PhA== =JNOI -----END PGP SIGNATURE----- --Arg+ym/KN0kWx7DB--