Date: Fri, 9 Sep 2022 09:03:06 +0200 From: Gordon Bergling <gbe@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f0d4c2afd65f - main - pmc(3): Correct some typos in event descriptions Message-ID: <YxrlKgHCe/kpWsvr@lion.ttyv0.de> In-Reply-To: <CAPyFy2Ah4-=r2vA5tHR9k7%2BOnPPigZdkzrhDxkKcTtG6b_2AYg@mail.gmail.com> References: <202209041052.284Aqvu2007702@gitrepo.freebsd.org> <05b97d9c-ff1d-0da2-ee22-0c054e853a77@FreeBSD.org> <CAPyFy2Ah4-=r2vA5tHR9k7%2BOnPPigZdkzrhDxkKcTtG6b_2AYg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Arg+ym/KN0kWx7DB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 08, 2022 at 09:32:32AM -0400, Ed Maste wrote: > On Wed, 7 Sept 2022 at 13:41, John Baldwin <jhb@freebsd.org> wrote: > > > --- > > > lib/libpmc/pmu-events/arch/x86/broadwell/pipeline.json | 4 += +-- > > > lib/libpmc/pmu-events/arch/x86/broadwellde/pipeline.json | 4 += +-- > > > lib/libpmc/pmu-events/arch/x86/broadwellx/pipeline.json | 4 += +-- > > > lib/libpmc/pmu-events/arch/x86/cascadelakex/uncore-other.json | 2 +- > > > lib/libpmc/pmu-events/arch/x86/silvermont/pipeline.json | 4 += +-- > > > lib/libpmc/pmu-events/arch/x86/skylakex/uncore-other.json | 2 +- > > > > I think these files are actually 3rd party (and should really be under > > contrib/ in that case?) so probably shouldn't be changed. Maybe you can > > send the changes upstream to Linux instead? >=20 > Yes, these come from Linux and the fixes should be sent there. The > process is a bit cumbersome but at least well documented; I've done it > for a couple of pmu-events files before, e.g. > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=3D= 28396b7df09b9565f404591c9945eac43526cb3f >=20 > The process is documented in the Linux source tree at > Documentation/process/submitting-patches.rst I wasn't aware that those event files come from Linux. I will submit the fi= xes upstream. If I remember correctly I have done some more spelling fixes, so I diff the whole directory against recent Linux sources. About the move to contrib, I could do that, but before I invest work in that direction, a decision should be made before that. --Gordon --Arg+ym/KN0kWx7DB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmMa5ShfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYx QjU4OEQwQTYzOTVGQkM4N0ZDNUNCODM5MDVGNjU3Q0FDRkQzREMACgkQOQX2V8rP 09ycGgf/b0bkQ++kL3diM5RH/+l4/WAKE81PkUxdMeN8FN/MRwE4pqfNzNp1yreq 5h2OM5nzAhgbzpMoCTbw2rf5qkxuAReIMZQW5IwT89vsElYiOhP9gqHgzH+Unnka kKLeU4espv6IkOqjBSXSmFkD5/xl/un2EUqtfxituKqwyeAFvmrKqinnY+zc9nkg r0+mOeQI42JGk/SO6VhS2WD1hqNMdjyDNdjljtwKeHXt867Ko+SvPPvXgw4NByi9 DiMxxYR6zRsVXJA7k5CZSJ6L8RUM5LJHvbx2L8QATP+ZjgyXCraNkL1Cw86kvx+4 t/yZmSHWghinSHgjn6RFqmmaAE2PhA== =JNOI -----END PGP SIGNATURE----- --Arg+ym/KN0kWx7DB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YxrlKgHCe/kpWsvr>