From owner-cvs-src@FreeBSD.ORG Mon Jan 2 12:28:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E145416A41F; Mon, 2 Jan 2006 12:28:00 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from gw.Awfulhak.org (S010600122564e0db.vn.shawcable.net [24.87.90.96]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2947643D45; Mon, 2 Jan 2006 12:27:56 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.13.4/8.13.4) with ESMTP id k02CRp6b034017; Mon, 2 Jan 2006 04:27:51 -0800 (PST) (envelope-from brian@FreeBSD.org) Date: Mon, 2 Jan 2006 04:27:51 -0800 From: Brian Somers To: Andrey Chernov Message-ID: <20060102042751.0200a731@dev.lan.Awfulhak.org> In-Reply-To: <20060102105258.GA9555@nagual.pp.ru> References: <200601020946.k029kdUU053109@repoman.freebsd.org> <20060102105258.GA9555@nagual.pp.ru> X-Mailer: Sylpheed-Claws 1.9.15 (GTK+ 2.6.9; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Brian Somers , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2006 12:28:01 -0000 On Mon, 2 Jan 2006 13:52:58 +0300 Andrey Chernov wrote: > On Mon, Jan 02, 2006 at 09:46:39AM +0000, Brian Somers wrote: > > usr.bin/su su.c > > Log: > > Handle the case (that I just broke) where the following hangs: > > > > $ su > > # kill -STOP $$ > > You broke not only that. > "stop $$/fg" for tcsh is broken now too (cause logout for ssh). > (BTW, this test is from commit logs) > > -- > http://ache.pp.ru/ > I've looked into this a little... csh blows up quite impressively here were (a)sh, bash and zsh work properly. My guess is that the bug is in tcsh and the code removed from su was just wrong anyway. I'll look into this further tomorrow (it's getting late here now) and I need to be up early in the morning. Hopefully I'll come up with something useful soon. -- Brian Somers Don't _EVER_ lose your sense of humour !