From owner-svn-src-all@FreeBSD.ORG  Wed Jan 13 08:53:23 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C951A1065672;
	Wed, 13 Jan 2010 08:53:23 +0000 (UTC)
	(envelope-from davidxu@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id B8B648FC17;
	Wed, 13 Jan 2010 08:53:23 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o0D8rNvT056532;
	Wed, 13 Jan 2010 08:53:23 GMT (envelope-from davidxu@svn.freebsd.org)
Received: (from davidxu@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o0D8rN5R056530;
	Wed, 13 Jan 2010 08:53:23 GMT (envelope-from davidxu@svn.freebsd.org)
Message-Id: <201001130853.o0D8rN5R056530@svn.freebsd.org>
From: David Xu <davidxu@FreeBSD.org>
Date: Wed, 13 Jan 2010 08:53:23 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r202185 - head/lib/libc/gen
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jan 2010 08:53:23 -0000

Author: davidxu
Date: Wed Jan 13 08:53:23 2010
New Revision: 202185
URL: http://svn.freebsd.org/changeset/base/202185

Log:
  Return SEM_FAILED instead of NULL, though there are same, but the
  SEM_FAILED is more suitable name.
  In function, sem_close(), always set errno on error.

Modified:
  head/lib/libc/gen/sem_new.c

Modified: head/lib/libc/gen/sem_new.c
==============================================================================
--- head/lib/libc/gen/sem_new.c	Wed Jan 13 08:21:19 2010	(r202184)
+++ head/lib/libc/gen/sem_new.c	Wed Jan 13 08:53:23 2010	(r202185)
@@ -147,13 +147,13 @@ _sem_open(const char *name, int flags, .
 
 	if (name[0] != '/') {
 		errno = EINVAL;
-		return (NULL);
+		return (SEM_FAILED);
 	}
 	name++;
 
 	if (flags & ~(O_CREAT|O_EXCL)) {
 		errno = EINVAL;
-		return (NULL);
+		return (SEM_FAILED);
 	}
 
 	_pthread_once(&once, sem_module_init);
@@ -275,6 +275,7 @@ _sem_close(sem_t *sem)
 		return (0);
 	}
 	_pthread_mutex_unlock(&sem_llock);
+	errno = EINVAL;
 	return (-1);
 }