From owner-dev-commits-ports-main@freebsd.org  Wed Jul 28 17:25:35 2021
Return-Path: <owner-dev-commits-ports-main@freebsd.org>
Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6331D661731;
 Wed, 28 Jul 2021 17:25:35 +0000 (UTC)
 (envelope-from i.h8.git@BSDforge.com)
Received: from udns.ultimatedns.net (static-24-113-41-81.wavecable.com
 [24.113.41.81])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "ultimatedns.net", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GZgXt6VP4z3mKp;
 Wed, 28 Jul 2021 17:25:34 +0000 (UTC)
 (envelope-from i.h8.git@BSDforge.com)
Received: from ultimatedns.net (localhost [127.0.0.1])
 by udns.ultimatedns.net (8.16.1/8.16.1) with ESMTP id 16SHPLsM093439;
 Wed, 28 Jul 2021 10:25:27 -0700 (PDT)
 (envelope-from i.h8.git@BSDforge.com)
MIME-Version: 1.0
Date: Wed, 28 Jul 2021 10:25:21 -0700
From: Chris <i.h8.git@BSDforge.com>
To: Alexey Dokuchaev <danfe@freebsd.org>
Cc: Matthias Andree <mandree@freebsd.org>, ports-committers@freebsd.org,
 dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: 17db9a3291e9 - main - Mk/bsd.port.mk: fix typo in .warning
In-Reply-To: <YPk6d/9l1EAnX386@FreeBSD.org>
References: <202107220923.16M9NTCs062056@gitrepo.freebsd.org>
 <YPk6d/9l1EAnX386@FreeBSD.org>
User-Agent: UDNSMS/17.0
Message-ID: <d60a4b9fda511775ed46d15d08a97824@BSDforge.com>
X-Sender: i.h8.git@BSDforge.com
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4GZgXt6VP4z3mKp
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [0.00 / 15.00];
 ASN(0.00)[asn:11404, ipnet:24.113.0.0/16, country:US];
 local_wl_ip(0.00)[24.113.41.81]
X-BeenThere: dev-commits-ports-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commits to the main branch of the FreeBSD ports repository
 <dev-commits-ports-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-main>, 
 <mailto:dev-commits-ports-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-main/>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Help: <mailto:dev-commits-ports-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-main>, 
 <mailto:dev-commits-ports-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jul 2021 17:25:35 -0000

On 2021-07-22 02:29, Alexey Dokuchaev wrote:
> On Thu, Jul 22, 2021 at 09:23:29AM +0000, Matthias Andree wrote:
>> commit 17db9a3291e9e8b62af035ee1b22160be465976a
>> 
>>     Mk/bsd.port.mk: fix typo in .warning
>> 
>>     vertion -> version.
>> 
>> --- a/Mk/bsd.port.mk
>> +++ b/Mk/bsd.port.mk
>> @@ -1216,7 +1216,7 @@ _PKG_BEFORE_PKGEXT!= ${PKG_BIN} version -t 
>> ${_PKG_VERSION:C/-.*//g} 1.17.0
>>  .if ${_PKG_BEFORE_PKGEXT} == "<"
>>  _PKG_TRANSITIONING_TO_NEW_EXT=	yes
>>  _EXPORTED_VARS+=	_PKG_TRANSITIONING_TO_NEW_EXT
>> -.warning "It is strongly recommanded to upgrade to a newer vertion of pkg 
>> first"
>> +.warning "It is strongly recommanded to upgrade to a newer version of pkg 
>> first"
> 
> When fixing typos, it's usually a good idea to check if thre are more
> of them around (e.g., "recommanded").  I'd probably just grepped for
> .warning and .error strings and run aspell(1) over them.
> 
> ./danfe
A humble suggestion to change:
.warning "It is strongly recommanded to upgrade to a newer version of pkg 
first
to
.warning "It is strongly recommended that you upgrade to a newer version of 
pkg first
or
.warning "You are strongly encouraged to upgrade to a newer version of pkg 
first

FWIW :-)

--Chris