Date: Mon, 12 Apr 2021 23:41:58 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: Adriaan de Groot <adridg@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 50731b13c882 - main - devel/kf5-extra-cmake-modules: make compatible with OpenEXR/Imath 3.0 Message-ID: <51e76378-549f-978f-0442-a9802fcf8c4a@FreeBSD.org> In-Reply-To: <2440935.0dHE6SNnxz@beastie.bionicmutton.org> References: <202104120034.13C0YB4k092091@gitrepo.freebsd.org> <2440935.0dHE6SNnxz@beastie.bionicmutton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 12.04.21 um 11:18 schrieb Adriaan de Groot: > On Monday, 12 April 2021 02:34:11 CEST Matthias Andree wrote: >> devel/kf5-extra-cmake-modules: make compatible with OpenEXR/Imath 3.0 > > Have you tried upstreaming any of this? It *seems* like adjusting-to-Imath is > required to build against OpenEXR 3.0, and in due course everyone (that is, us > and the Linux world) is going to have that, so upstream needs to adjust > anyway. Hi Adrian, I haven't yet, but we should try to do that, and we should also approach the Academy Software Foundation to ask them to provide a canonical cmake find module, I've seen too many diverse approaches. pkg-config might actually be simplest, most GNU autoconf based ports use that and they have been a lot easier to update. I think there was some copying going on from the OpenEXR-finder-for-cmake from Blender, and lots of homebrewn stuff... too much freedom in mmake. > (Of course, upstreaming means dealing with both old- and new-OpenEXR and > handling paths and builds nicely) Exactly the reason why I've for now patched our ports locally first, to avoid a chicken-and-hen circular dependency... Cheers, Matthias
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51e76378-549f-978f-0442-a9802fcf8c4a>