From owner-cvs-all@FreeBSD.ORG Fri Sep 21 11:53:44 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 937F616A418; Fri, 21 Sep 2007 11:53:44 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 540D213C459; Fri, 21 Sep 2007 11:53:44 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from tirith.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189]) by solow.pil.dk (Postfix) with ESMTP id DD0171CC107; Fri, 21 Sep 2007 13:53:42 +0200 (CEST) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id BB6841701B; Fri, 21 Sep 2007 13:53:41 +0200 (CEST) Date: Fri, 21 Sep 2007 13:53:41 +0200 From: Henrik Brix Andersen To: Kevin Lo Message-ID: <20070921115341.GD1501@tirith.brixandersen.dk> Mail-Followup-To: Kevin Lo , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200709190204.l8J24llM050769@repoman.freebsd.org> <20070919090501.GA2479@tirith.brixandersen.dk> <1190351847.6206.5.camel@monet> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kXdP64Ggrk/fb43R" Content-Disposition: inline In-Reply-To: <1190351847.6206.5.camel@monet> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/getfacl getfacl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2007 11:53:44 -0000 --kXdP64Ggrk/fb43R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 21, 2007 at 01:17:27PM +0800, Kevin Lo wrote: > Henrik Brix Andersen wrote: > > On Wed, Sep 19, 2007 at 02:04:47AM +0000, Kevin Lo wrote: > > > kevlo 2007-09-19 02:04:47 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > bin/getfacl getfacl.c=20 > > > Log: > > > Use owner name and owning group name instead of uid and gid > > > for displaying the three-line comment header by default. > > > =20 > > > Reviewed by: kientzle > > > Approved by: re (bmah) > >=20 > > Isn't this a POLA violation? At least I think it should be mentioned > > in UPDATING as people might (I know I do) have scripts, that actually > > parse the uid/gid fields in the header. >=20 > How about adding a "-n" option to display user and group IDs=20 > numerically? thoughts? That may be overkill... As far as I am concerned, a simple entry in UPDATING is sufficient. Here's my suggested patch: --- /usr/src/UPDATING 2007-07-09 11:11:19.000000000 +0200 +++ UPDATING 2007-09-21 13:50:33.000000000 +0200 @@ -21,6 +21,12 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 7. developers choose to disable these features on build machines to maximize performance. =20 +20070921: + The getfacl(1) utility now prints owning user and group name + instead of owning uid and gid in the three line comment + header. This is the same behavior as getfacl(1) on Solaris and + Linux. + 20070704: The new IPsec code is now compiled in using the IPSEC option. The IPSEC option now requires "device crypto" be defined in your kernel Regards, Brix --=20 Henrik Brix Andersen --kXdP64Ggrk/fb43R Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: GnuPG signed iD8DBQFG87DFv+Q4flTiePgRAiO7AKC4tTMjgSg8n/3IIqDQjnkb+b7gbwCgmWPa py958hJz6OFE0xHuKaUHm7Y= =+28e -----END PGP SIGNATURE----- --kXdP64Ggrk/fb43R--