From owner-p4-projects@FreeBSD.ORG Fri Apr 9 23:55:10 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0AC5A16A4D0; Fri, 9 Apr 2004 23:55:10 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4B8816A4CE for ; Fri, 9 Apr 2004 23:55:09 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDC1843D2D for ; Fri, 9 Apr 2004 23:55:09 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i3A6t9Ge090808 for ; Fri, 9 Apr 2004 23:55:09 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i3A6t9nS090782 for perforce@freebsd.org; Fri, 9 Apr 2004 23:55:09 -0700 (PDT) (envelope-from scottl@freebsd.org) Date: Fri, 9 Apr 2004 23:55:09 -0700 (PDT) Message-Id: <200404100655.i3A6t9nS090782@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to scottl@freebsd.org using -f From: Scott Long To: Perforce Change Reviews Subject: PERFORCE change 50771 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2004 06:55:10 -0000 http://perforce.freebsd.org/chv.cgi?CH=50771 Change 50771 by scottl@scottl-junior-camlock on 2004/04/09 23:54:15 Lock Giant around the call to xpt_action in the work thread. Simple tests seem to kinda indicate that this actually works! Affected files ... .. //depot/projects/scottl-camlock/src/sys/cam/cam_probe.c#4 edit Differences ... ==== //depot/projects/scottl-camlock/src/sys/cam/cam_probe.c#4 (text+ko) ==== @@ -149,7 +149,9 @@ switch (work->command) { case WORK_EXECUTE_CCB: + mtx_lock(&Giant); xpt_action((union ccb *)work->data); + mtx_unlock(&Giant); break; default: panic("Unknown CAM work item %d\n", work->command);