From owner-cvs-all@FreeBSD.ORG Sun Mar 13 18:56:52 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0D261065670; Sun, 13 Mar 2011 18:56:52 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 036818FC12; Sun, 13 Mar 2011 18:56:51 +0000 (UTC) Received: by bwz12 with SMTP id 12so4405014bwz.13 for ; Sun, 13 Mar 2011 11:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=wD9WKSkUQba7R+B5dhhosIKLCUtKMWZ8oGO/D0dusjs=; b=kCWuFtqfXHObGnmgPQ2cPflWaefkCLvnkmJhIC2U5zM4PufIgYXsig0yLILVShLT4n FdnUti7vK5MOf1bph1qPizEklBY6FiCkF/dWkODaGjNhYhs8U8gV0m08/zu1nOF/84YI XNXiROpRSuZhE4gKkB6B1MEKhY0NxhfcAPHZ8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; b=SnXa4WrAxW5JRVw5qOG+JriMGsp5x00EXsx2o9oactBPjFELW2FTPaKcVT5RsXPJ8z MmwFJshjUqHLk+Wim1yY7tYXisO+U4ZtR9Ait7FRodt/9vHNtymG+DI9DhjVCAQKw70D 4406esikN/D6/Muguuzbu25vsM6wvjNRuZNWg= MIME-Version: 1.0 Received: by 10.204.141.14 with SMTP id k14mr5576081bku.37.1300041014388; Sun, 13 Mar 2011 11:30:14 -0700 (PDT) Received: by 10.204.173.194 with HTTP; Sun, 13 Mar 2011 11:30:14 -0700 (PDT) Received: by 10.204.173.194 with HTTP; Sun, 13 Mar 2011 11:30:14 -0700 (PDT) In-Reply-To: <19836.64221.439373.622680@gromit.timing.com> References: <201103091401.p29E1mtM086605@repoman.freebsd.org> <4D798BD2.2030400@FreeBSD.org> <19836.64221.439373.622680@gromit.timing.com> Date: Sun, 13 Mar 2011 18:30:14 +0000 Message-ID: From: Chris Rees To: John Hein Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Doug Barton , Martin Wilke , cvs-all@freebsd.org, ports-committers@freebsd.org, cvs-ports@freebsd.org, john.c.prather@gmail.com Subject: Re: cvs commit: ports/mail/davmail Makefile distinfo pkg-plist ports/mail/davmail/files davmail.in davmail.properties.sample davmail.sh.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: utisoft@gmail.com List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Mar 2011 18:56:53 -0000 Thanks John and Doug, I'll revise the rc script when CTM gets my tree back up to date. Chris On 13 Mar 2011 17:12, "John Hein" wrote: > Doug Barton wrote at 18:41 -0800 on Mar 10, 2011: > > Couple of comments on the rc.d script: > > > > 1. The %%PORTNAME%% obfuscation isn't worth the effort. It doesn't have > > any good benefits that make it worth causing the difficulty in reading > > the script in the tree. > > 2. If the script starts a persistent service (which it seems to) it > > needs "KEYWORD: SHUTDOWN" > > 3. procname probably wants to be command_interpreter, but that should be > > tested. > > This was actually a combination of two PRs. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=154903 > http://www.freebsd.org/cgi/query-pr.cgi?pr=154982 > > The rc mods were from 154903 & Chris Rees (now CC'd).