Date: Sun, 6 May 2018 10:50:12 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: Koichiro Iwao <meta@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506105012.GA39087@FreeBSD.org> In-Reply-To: <20180506103420.GW25490@fc.opsec.eu> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <20180506103420.GW25490@fc.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 06, 2018 at 12:34:20PM +0200, Kurt Jaeger wrote: > > On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote: > > > New Revision: 469188 > > > URL: https://svnweb.freebsd.org/changeset/ports/469188 > > > > > > Log: > > > ports-mgmt/pkg_replace: Update to 20180424 > > > > > > - Cleanup code > > > - Speed up and strictly check package's dependencies > > > - While here, pet portlint by using pkg-plist instead of PLIST_FILES > > > > Could you explain what did you achieve by moving three-line PLIST_FILES > > into pkg-plist? How can "pet portlint" be a reason for a change while > > we generally encourage converting <6-line pkg-plist's into PLIST_FILES? > > There was a problem if the pkg-list stayed in PLIST_FILES > (the build in poudriere failed with a signal 6 in make package). > > Koichiro is working to reproduce/report this, until then... *facepalm*. This poudriere-driven development is more and more disturbing. You didn't attempt to understand the problem, you didn't attempt to fix the PLIST_FILES (remove bogus %%ETCDIR%% since this is Makefile), you didn't ask for a peer review. meta@ pessimized the port, provided wrong commit log (it tells *nothing* about poudriere failing with a signal 6 in make package, it says "pet portlint"), and you've approved it like there's nothing wrong with all of this. :-( ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180506105012.GA39087>