Date: Sun, 13 Mar 2011 18:30:14 +0000 From: Chris Rees <utisoft@gmail.com> To: John Hein <jhein@symmetricom.com> Cc: Doug Barton <dougb@freebsd.org>, Martin Wilke <miwi@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org, cvs-ports@freebsd.org, john.c.prather@gmail.com Subject: Re: cvs commit: ports/mail/davmail Makefile distinfo pkg-plist ports/mail/davmail/files davmail.in davmail.properties.sample davmail.sh.in Message-ID: <AANLkTinO1ffDsU2CktP135pGi%2B_1Svwfo3XMwoN%2BBd5j@mail.gmail.com> In-Reply-To: <19836.64221.439373.622680@gromit.timing.com> References: <201103091401.p29E1mtM086605@repoman.freebsd.org> <4D798BD2.2030400@FreeBSD.org> <19836.64221.439373.622680@gromit.timing.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks John and Doug, I'll revise the rc script when CTM gets my tree back up to date. Chris On 13 Mar 2011 17:12, "John Hein" <jhein@symmetricom.com> wrote: > Doug Barton wrote at 18:41 -0800 on Mar 10, 2011: > > Couple of comments on the rc.d script: > > > > 1. The %%PORTNAME%% obfuscation isn't worth the effort. It doesn't have > > any good benefits that make it worth causing the difficulty in reading > > the script in the tree. > > 2. If the script starts a persistent service (which it seems to) it > > needs "KEYWORD: SHUTDOWN" > > 3. procname probably wants to be command_interpreter, but that should be > > tested. > > This was actually a combination of two PRs. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=154903 > http://www.freebsd.org/cgi/query-pr.cgi?pr=154982 > > The rc mods were from 154903 & Chris Rees (now CC'd).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinO1ffDsU2CktP135pGi%2B_1Svwfo3XMwoN%2BBd5j>