From owner-freebsd-fs@FreeBSD.ORG Fri Mar 25 18:13:40 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D599D106566C for ; Fri, 25 Mar 2011 18:13:40 +0000 (UTC) (envelope-from giffunip@tutopia.com) Received: from nm23-vm0.bullet.mail.sp2.yahoo.com (nm23-vm0.bullet.mail.sp2.yahoo.com [98.139.91.224]) by mx1.freebsd.org (Postfix) with SMTP id 95EFD8FC19 for ; Fri, 25 Mar 2011 18:13:40 +0000 (UTC) Received: from [98.139.91.68] by nm23.bullet.mail.sp2.yahoo.com with NNFMP; 25 Mar 2011 18:13:40 -0000 Received: from [98.139.91.7] by tm8.bullet.mail.sp2.yahoo.com with NNFMP; 25 Mar 2011 18:13:40 -0000 Received: from [127.0.0.1] by omp1007.mail.sp2.yahoo.com with NNFMP; 25 Mar 2011 18:13:40 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 256519.6971.bm@omp1007.mail.sp2.yahoo.com Received: (qmail 92667 invoked by uid 60001); 25 Mar 2011 18:13:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1301076819; bh=4ReYo6JFQmTn39wDK7tnjF+Xkkn8tQ3nF/W2YRU1ZQY=; h=Message-ID:X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=kXNy5oZ4aM0FzJPqMym9VQjbJ8woSJosbso5Z9oHGnfmZ1XEC6nrTiQHzz9fO3JBYg2LYaIe2ZFKUGyO7kJCFqq3NWl1J8TrgXFrrkPruYRFpCgLLNsDj4Yx0HHmPrm9NQwjf57nM6daPphkBGjrI0H++RyhfNPD3Cib2HOwmWk= Message-ID: <758552.89055.qm@web113514.mail.gq1.yahoo.com> X-YMail-OSG: FADhkkUVM1nZELD9pvl1XSnwo02c3Duq0uIiPToS2LR9Sd. 7PDOodttsY9nUpo5mUM7lx9mOS1HHAqyMYq6nhGWvpeu_2MvrJXA1xv_UoWR q28tIZ9YrQjRUoC1ZobcSPd2Y8NrFQNGS_odgnNijBZMgbgx1mBlLsG2EB3q Y0C0pd1H1jEragZUqIY0v5wga4uIKO76Mm5K8a7qEy9CrfZP9XTHyE7mBCNb IXvvJjD2GWqMqiENiGPc61.7FLkDxPurUsvcPpzqZcW4Df70r_hK7vyz_rZo HiCVqs2iaaGxNCJPFEL5C.a8S6d1ZpbDkDdKcScoPgcxqIyeKFUjW2C1Yfbv bzAqRxPP0gUx0ySC9ZPeTRA1g50EIvvqMNRelmL86tggXcxVjsH9aToihbV_ yy1Xh.e6Wy0nm Received: from [200.118.159.55] by web113514.mail.gq1.yahoo.com via HTTP; Fri, 25 Mar 2011 11:13:39 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/12.0.2 YahooMailWebService/0.8.109.295617 Date: Fri, 25 Mar 2011 11:13:39 -0700 (PDT) From: "Pedro F. Giffuni" To: Kostik Belousov In-Reply-To: <20110325165314.GO78089@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: giffunip@tutopia.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2011 18:13:40 -0000 Hello;=0A--- On Fri, 3/25/11, Kostik Belousov wrote:= =0A...=0A> >=A0 Fixes NetBSD PR #44661=0A> Can you extract the test referen= ced in the commit message=0A> ?=0AHere is the NetBSD link:=0A=0Ahttp://cvsw= eb.netbsd.org/bsdweb.cgi/src/tests/fs/vfs/t_vnops.c.diff?r1=3D1.21&r2=3D1.2= 2=0A=0Abut I have no idea if it will apply to our testing framework.=0A=0A>= =0A> I think that s/EROFS/EINVAL/ change could and should be=0A> committed= first, and then the (potential) fix for the=0A> vnode leakage as a separat= e commit.=0A>=0A=0AIt takes some time to get patches committed, so I usuall= y=0Aprefer to submit bigger patches, if I can, in order to save=0Areviewer'= s time.=0A=0AFWIW, I prefer so much bugzilla since permits better patch=0Ah= andling and obsoleting the diffs that have been applied=0Aalready. =0A=0A= =0A