Date: Sat, 16 Apr 2022 17:56:29 -0500 From: Larry Rosenman <ler@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Neel Chauhan <nc@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 0dd69d0adfd2 - main - mail/dovecot: Add FLAVORs for CDB, LDAP, MYSQL, PGSQL, and SQLITE3 Message-ID: <0d7878ec04505a9f478f02746523efc1@FreeBSD.org> In-Reply-To: <20220416225515.qppw6vzsebek6ns3@aching.in.mat.cc> References: <202204152248.23FMmKfV041481@gitrepo.freebsd.org> <20220416225515.qppw6vzsebek6ns3@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/16/2022 5:55 pm, Mathieu Arnold wrote: > On Fri, Apr 15, 2022 at 10:48:20PM +0000, Neel Chauhan wrote: >> The branch main has been updated by nc: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=0dd69d0adfd2ef48dc949bb2325c2c534117fc29 >> >> commit 0dd69d0adfd2ef48dc949bb2325c2c534117fc29 >> Author: Neel Chauhan <nc@FreeBSD.org> >> AuthorDate: 2022-04-15 22:47:24 +0000 >> Commit: Neel Chauhan <nc@FreeBSD.org> >> CommitDate: 2022-04-15 22:48:18 +0000 >> >> mail/dovecot: Add FLAVORs for CDB, LDAP, MYSQL, PGSQL, and SQLITE3 > > You are probably abusing flavors to get subpackages, please revert. I already reverted it :) > >> PR: 254164 >> Approved by: maintainer timeout (>1 year) >> --- >> mail/dovecot/Makefile | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/mail/dovecot/Makefile b/mail/dovecot/Makefile >> index 0379f598643f..4b96bf4c4506 100644 >> --- a/mail/dovecot/Makefile >> +++ b/mail/dovecot/Makefile >> @@ -23,6 +23,14 @@ LIB_DEPENDS= libzstd.so:archivers/zstd >> USES= cpe iconv libtool pkgconfig ssl >> USE_RC_SUBR= dovecot >> >> +FLAVORS= default cdb ldap mysql pgsql sqlite3 >> +FLAVOR?= ${FLAVORS:[1]} >> +cdb_PKGNAMESUFFIX= -cdb >> +ldap_PKGNAMESUFFIX= -ldap >> +mysql_PKGNAMESUFFIX= -mysql >> +pgsql_PKGNAMESUFFIX= -pgsql >> +sqlite3_PKGNAMESUFFIX= -sqlite3 >> + >> GNU_CONFIGURE= yes >> CONFIGURE_ARGS= --localstatedir=/var \ >> --with-docs \ >> @@ -48,6 +56,22 @@ OPTIONS_GROUP_FTS= ICU LUCENE SOLR TEXTCAT >> OPTIONS_SINGLE= GSSAPI >> OPTIONS_SINGLE_GSSAPI= GSSAPI_NONE GSSAPI_BASE GSSAPI_HEIMDAL >> GSSAPI_MIT >> >> +.if ${FLAVOR} == cdb >> +OPTIONS_DEFAULT+= CDB >> +.endif >> +.if ${FLAVOR} == ldap >> +OPTIONS_DEFAULT+= LDAP >> +.endif >> +.if ${FLAVOR} == mysql >> +OPTIONS_DEFAULT+= MYSQL >> +.endif >> +.if ${FLAVOR} == pgsql >> +OPTIONS_DEFAULT+= PGSQL >> +.endif >> +.if ${FLAVOR} == sqlite3 >> +OPTIONS_DEFAULT+= SQLITE3 >> +.endif >> + >> DB_DESC= Database support >> CDB_DESC= CDB database support >> >> -- Larry Rosenman http://people.freebsd.org/~ler Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0d7878ec04505a9f478f02746523efc1>