From owner-cvs-src@FreeBSD.ORG Sat Jul 3 19:17:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB1F116A4CE; Sat, 3 Jul 2004 19:17:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B552843D31; Sat, 3 Jul 2004 19:17:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i63JH6ms095917; Sat, 3 Jul 2004 19:17:06 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i63JH6wO095916; Sat, 3 Jul 2004 19:17:06 GMT (envelope-from rwatson) Message-Id: <200407031917.i63JH6wO095916@repoman.freebsd.org> From: Robert Watson Date: Sat, 3 Jul 2004 19:17:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/nfsserver nfs_srvcache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jul 2004 19:17:06 -0000 rwatson 2004-07-03 19:17:06 UTC FreeBSD src repository Modified files: sys/nfsserver nfs_srvcache.c Log: Change M_WAITOK argument to sodupsockaddr() to M_NOWAIT. When the call to dup_sockaddr() was renamed to sodupsockaddr(), the argument was changed from '1' to 'M_WAITOK', which changed the semantics. This resulted in a WITNESS warning about a potential sleep while holding the NFS server mutex. Now this will no longer happen, restoring a possible bug present in the original code (setting RC_NAM even though the malloc to copy the addres may fail). bde observes that the flag names here should probably not be the same as the malloc flags for name space reasons. Bumped into by: kuriyama Revision Changes Path 1.39 +5 -1 src/sys/nfsserver/nfs_srvcache.c