From owner-p4-projects@FreeBSD.ORG  Thu Jul 30 12:44:02 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id CDAAA1065670; Thu, 30 Jul 2009 12:44:01 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8D0B6106566C
	for <perforce@freebsd.org>; Thu, 30 Jul 2009 12:44:01 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7B5DE8FC08
	for <perforce@freebsd.org>; Thu, 30 Jul 2009 12:44:01 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n6UCi1mT047484
	for <perforce@freebsd.org>; Thu, 30 Jul 2009 12:44:01 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n6UCi1cc047482
	for perforce@freebsd.org; Thu, 30 Jul 2009 12:44:01 GMT
	(envelope-from jhb@freebsd.org)
Date: Thu, 30 Jul 2009 12:44:01 GMT
Message-Id: <200907301244.n6UCi1cc047482@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 166785 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2009 12:44:02 -0000

http://perforce.freebsd.org/chv.cgi?CH=166785

Change 166785 by jhb@jhb_jhbbsd on 2009/07/30 12:43:09

	Remove extraneous locking to read fd_cmask in one other place.
	The rest of the tree already read fd_cmask w/o locking.

Affected files ...

.. //depot/projects/smpng/sys/fs/unionfs/union_subr.c#39 edit

Differences ...

==== //depot/projects/smpng/sys/fs/unionfs/union_subr.c#39 (text+ko) ====

@@ -486,9 +486,7 @@
 		}
 		break;
 	default:		/* UNIONFS_TRADITIONAL */
-		FILEDESC_SLOCK(td->td_proc->p_fd);
 		uva->va_mode = 0777 & ~td->td_proc->p_fd->fd_cmask;
-		FILEDESC_SUNLOCK(td->td_proc->p_fd);
 		uva->va_uid = ump->um_uid;
 		uva->va_gid = ump->um_gid;
 		break;