From nobody Wed Jun 11 17:08:11 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHXDT0Djjz5yBJh for ; Wed, 11 Jun 2025 17:08:25 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHXDS3qbJz3fmc for ; Wed, 11 Jun 2025 17:08:24 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a376ba6f08so82833f8f.1 for ; Wed, 11 Jun 2025 10:08:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749661703; x=1750266503; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6BYhsnkdkOPW7JjrUxisLuMyBW8V13cf/aMmGgIX8hc=; b=uV1KMAdKrAc7wUTU7X2I/zYaHGEJW9JjKWd+MuGSQHhY9OG9k/9nK1C7VqKkdd09no uAR0FrRBEiMq3SL7n5u7gy1cgUWHPFDbsYud4MRoPOJHO44uZd79Usbqx4eVzD7mCsH1 7HL17f6lPQCR05h8HDwjB8ic9tKO8gfwZuX4iLf+MFzgrvE2Y7B5I7WzgEySTxQNK0pv 6oHFacK5xc0dHYULm0iBIVj3XbTTjVxkg5IFY0fQ0v2pTrUs96S9hsGp1ZlnqcYX4MF9 pqtKUPCCFsDhbD0XYOub7O8S/0hXgF8sSf8Ifk86dT3sDDnk3UakV/aNakQ6tjmr4MTg YOMA== X-Forwarded-Encrypted: i=1; AJvYcCXAtmFShnsnJmO0ZcOEip/NjJHc6Q8ternNA+QrzCykaK7s73RsZi7zO2qdDdZ2u5XTUbXg72il71v8C0dm0/NAvYVe@freebsd.org X-Gm-Message-State: AOJu0YyAcX5kBq2dahLjZibg52WpZeOB1kcPJKwq1mc8JIVz0ExXkM3C 56EoqT+usRz5M9dRocPe4j6jZj0i0THHlwUi2fg01JSp/dN+t9/nclyzuEn0T3SVSug= X-Gm-Gg: ASbGncs8Za/6O61a8/grNacjCG4ZiyhUlvuq/RuYCXNXMHmmuQfxUFjaaRnyyHXGlBJ ZQJnFNp7Y0iadWA65MVv/hM2nmfo2+fM4iCRXToXEOuPWF9HDiq1FOobVKf1ZpGHIG1sM7mgts7 XwnQ5GO5gz/f0KMwQmK6bkioNz40P+/hW8f8uZ7b09J0Qdaa9/yBsG8A1D5jVQQ9w0nfnvSf9N7 CHueH3NS92oeyr1qZN8O4y5pBY8AjAdJo90fPbhkWI/J8HQSSUq1+3gn5urwMShC392I5yyMShv uqy1F+C6WKSBi8VEGAcqhUZubGWiQmV5Cz2hNch8skLiHMLpdX43QWm9aC+SqSJNltlA/fO+os8 EA27K5HMw9+Y= X-Google-Smtp-Source: AGHT+IEIfQAMETLePrpEEzS9QpyMFaAK8/AdrArUuHoFRViz+LYIZ3T6LqzcrG7al5ymyKl3AZqxYg== X-Received: by 2002:a05:6000:288c:b0:3a5:266f:e6fb with SMTP id ffacd0b85a97d-3a558a455acmr3766313f8f.44.1749661702748; Wed, 11 Jun 2025 10:08:22 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45325215e75sm28172165e9.27.2025.06.11.10.08.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jun 2025 10:08:22 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: c190cd94b7bf - main - sys/_stdarg.h: drop cdefs.h and _types.h polution From: Jessica Clarke In-Reply-To: <202506111700.55BH0PPx042716@gitrepo.freebsd.org> Date: Wed, 11 Jun 2025 18:08:11 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202506111700.55BH0PPx042716@gitrepo.freebsd.org> To: Brooks Davis X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Rspamd-Queue-Id: 4bHXDS3qbJz3fmc X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On 11 Jun 2025, at 18:00, Brooks Davis wrote: >=20 > The branch main has been updated by brooks: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc190cd94b7bff590b06db906c5678952= 5a991ece >=20 > commit c190cd94b7bff590b06db906c56789525a991ece > Author: Brooks Davis > AuthorDate: 2025-06-11 16:39:02 +0000 > Commit: Brooks Davis > CommitDate: 2025-06-11 16:39:02 +0000 >=20 > sys/_stdarg.h: drop cdefs.h and _types.h polution >=20 > Rely in sys/_visible for visibility macros and use __buitin_va_list > instead of __va_list everywere we declare va_list. This layout seems odd. I would expect sys/sys/_stdarg.h to define __va_list, which stdio.h and wchar.h can then include and use __va_list for their va_list, like how we do things for __[u]intN_t. Jess > Reviewed by: imp > Exp-run by: antoine (PR 286274) > Pull Request: https://github.com/freebsd/freebsd-src/pull/1595 > --- > include/stdio.h | 2 +- > include/wchar.h | 2 +- > sys/sys/_stdarg.h | 7 +++---- > 3 files changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/include/stdio.h b/include/stdio.h > index 3dedb8fd5a54..34e877b60c14 100644 > --- a/include/stdio.h > +++ b/include/stdio.h > @@ -74,7 +74,7 @@ typedef __off64_t off64_t; >=20 > #if __POSIX_VISIBLE >=3D 200112 || __XSI_VISIBLE > #ifndef _VA_LIST_DECLARED > -typedef __va_list va_list; > +typedef __builtin_va_list va_list; > #define _VA_LIST_DECLARED > #endif > #endif > diff --git a/include/wchar.h b/include/wchar.h > index e4b037c9b16f..bf07062935d5 100644 > --- a/include/wchar.h > +++ b/include/wchar.h > @@ -78,7 +78,7 @@ typedef __size_t size_t; >=20 > #if __POSIX_VISIBLE >=3D 200809 || __XSI_VISIBLE > #ifndef _VA_LIST_DECLARED > -typedef __va_list va_list; > +typedef __builtin_va_list va_list; > #define _VA_LIST_DECLARED > #endif > #endif > diff --git a/sys/sys/_stdarg.h b/sys/sys/_stdarg.h > index 063e59dc83f6..3886f4632b10 100644 > --- a/sys/sys/_stdarg.h > +++ b/sys/sys/_stdarg.h > @@ -31,12 +31,11 @@ > #ifndef _SYS__STDARG_H_ > #define _SYS__STDARG_H_ >=20 > -#include > -#include > +#include >=20 > #ifndef _VA_LIST_DECLARED > - #define _VA_LIST_DECLARED > - typedef __va_list va_list; > +#define _VA_LIST_DECLARED > +typedef __builtin_va_list va_list; > #endif >=20 > #define va_start(ap, last) __builtin_va_start((ap), (last))