From nobody Fri Dec 12 18:43:23 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dSddm431zz6K6hs; Fri, 12 Dec 2025 18:43:56 +0000 (UTC) (envelope-from br@bsdpad.com) Received: from mail.bsdpad.com (mail.bsdpad.com [91.99.52.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4dSddm16xDz3LmJ; Fri, 12 Dec 2025 18:43:56 +0000 (UTC) (envelope-from br@bsdpad.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bsdpad.com; s=20201212; h=From:To:Subject; bh=7Cbw+ViErRnm4BDy8XIrHI3044Yu4XOBW+TrM5omvwk=; b=n04K3Gch3ZS4B6ndiymKvi924S 97WuZVj63wgp+mpwF4oYvhtHt3CD/dnHLFqmVgFaDs3M3XZ7WIh/6fOY7ZXH7YspsHMA6ZpOclPEA tSJMBXYUu8UMlBqV2YqfM5Bowg9OFDnk3NIl1fSwEajm7auQFep+SmdbHKLE4Cskeh/bzH1MhWBbb Es9y4fyerN25xnzZKGXhordyXEyhOLCs4ScRAZrEfNyfoVpU3/GHiOraWz5VH+htW6Sr3UatOqVDe ZqBefEVVCV+DSLtVE7K/MIf+G8IYBo4aHAFe7s3B4c7GdVCQW4Icj3W+me1WT58Nq3YVJuuIuevB2 T9Y2e88Q==; Received: from mail.bsdpad.com ([91.99.52.19] helo=localhost) by mail.bsdpad.com with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.98.2 (FreeBSD)) (envelope-from ) id 1vU86t-00000000DKZ-2xJ6; Fri, 12 Dec 2025 18:43:23 +0000 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 12 Dec 2025 18:43:23 +0000 Message-Id: Cc: , , Subject: Re: git: c52253232a78 - main - xae(4): remove unused function. To: "Gleb Smirnoff" From: "Ruslan Bukin" X-Mailer: aerc References: <693c399d.354cb.f610b33@gitrepo.freebsd.org> In-Reply-To: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:91.99.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dSddm16xDz3LmJ On Fri Dec 12, 2025 at 4:56 PM UTC, Gleb Smirnoff wrote: > On Fri, Dec 12, 2025 at 03:49:49PM +0000, Ruslan Bukin wrote: > R> The branch main has been updated by br: > R>=20 > R> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc52253232a78dc2553d6ea7= c9ab3e92301b36c01 > R>=20 > R> commit c52253232a78dc2553d6ea7c9ab3e92301b36c01 > R> Author: Ruslan Bukin > R> AuthorDate: 2025-12-12 15:47:22 +0000 > R> Commit: Ruslan Bukin > R> CommitDate: 2025-12-12 15:49:37 +0000 > R>=20 > R> xae(4): remove unused function. > R> =20 > R> Sponsored by: CHERI Research Centre > R> --- > R> sys/dev/xilinx/if_xae.c | 6 ------ > R> 1 file changed, 6 deletions(-) > R>=20 > R> diff --git a/sys/dev/xilinx/if_xae.c b/sys/dev/xilinx/if_xae.c > R> index 7880f93c48ee..435902dc3c10 100644 > R> --- a/sys/dev/xilinx/if_xae.c > R> +++ b/sys/dev/xilinx/if_xae.c > R> @@ -543,11 +543,6 @@ xae_get_phyaddr(phandle_t node, int *phy_addr) > R> return (0); > R> } > R> =20 > R> -static void > R> -xae_qflush(if_t ifp) > R> -{ > R> -} > R> - > R> static void > R> xae_stop_locked(struct xae_softc *sc) > R> { > R> @@ -1239,7 +1234,6 @@ xae_attach(device_t dev) > R> if_setflags(ifp, IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST); > R> if_setcapabilities(ifp, IFCAP_VLAN_MTU); > R> if_setcapenable(ifp, if_getcapabilities(ifp)); > R> - if_setqflushfn(ifp, xae_qflush); > R> if_setioctlfn(ifp, xae_ioctl); > R> if_setstartfn(ifp, xae_txstart); > R> if_setinitfn(ifp, xae_init); > > This also means this code was never run with INVARIANTS. Otherwise it wo= uld > panic in if_attach_internal(). Indeed, but just a couple of week since I rewrote it. INVARIANTS were disab= led in my Codasip repo due to experiments with nvme(4), and I forgot re-enable! Ruslan