From owner-cvs-all Mon Apr 30 1:35:54 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.musha.org (daemon.musha.org [61.122.44.178]) by hub.freebsd.org (Postfix) with ESMTP id 9430F37B422; Mon, 30 Apr 2001 01:35:47 -0700 (PDT) (envelope-from knu@iDaemons.org) Received: from archon.local.idaemons.org (archon.local.idaemons.org [192.168.1.32]) by mail.musha.org (Postfix) with ESMTP id 6ED814DF4F; Mon, 30 Apr 2001 17:35:46 +0900 (JST) Date: Mon, 30 Apr 2001 17:35:46 +0900 Message-ID: <86elua4wf1.wl@archon.local.idaemons.org> From: "Akinori MUSHA" To: Kris Kennaway Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/fox/files patch-ad In-Reply-To: <200104300810.f3U8AGY60114@freefall.freebsd.org> References: <200104300810.f3U8AGY60114@freefall.freebsd.org> User-Agent: Wanderlust/2.5.4 (Smooth) SEMI/1.14.2 (=?ISO-8859-1?Q?Daish=F2?= =?ISO-8859-1?Q?ji?=) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 MULE XEmacs/21.1 (patch 14) (Cuyahoga Valley) (i386--freebsd) Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 081D 099C 1705 861D 4B70 B04A 920B EFC7 9FD9 E1EE MIME-Version: 1.0 (generated by SEMI 1.14.2 - =?ISO-8859-1?Q?=22Daish=F2ji=22?=) Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At Mon, 30 Apr 2001 01:10:16 -0700 (PDT), kkenn wrote: > kris 2001/04/30 01:10:16 PDT > > Modified files: > x11-toolkits/fox/files patch-ad > Log: > Don't hard-code -O2 and various -f optimizations in CXXFLAGS > > Revision Changes Path > 1.2 +37 -5 ports/x11-toolkits/fox/files/patch-ad Thanks, but I wasn't asked for a review in advance on this... At a glance, I noticed that /usr/local was hardcoded, which might be evil. Also, I haven't yet tested if this big monster of a toolkit works with optimization flags other than "-O2 -ffast-math -finline-functions -fomit-frame-pointer -fexpensive-optimizations". I wish you had pointed it to me rather than just committing directly. I am going to test it out soon and in any case I will put those default flags in the Makefile in a comment as recommendation, -- / /__ __ Akinori.org / MUSHA.org / ) ) ) ) / FreeBSD.org / Ruby-lang.org Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp "Freeze this moment a little bit longer, make each impression a little bit stronger.. Experience slips away -- Time stand still" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message