Date: Mon, 27 Jan 2014 12:19:07 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r341341 - head/devel/xwpe Message-ID: <20140127111907.GE30300@ithaqua.etoilebsd.net> In-Reply-To: <20140127103654.GA12714@FreeBSD.org> References: <201401270841.s0R8fjq3007225@svn.freebsd.org> <20140127092855.GA88072@FreeBSD.org> <20140127102231.GD30300@ithaqua.etoilebsd.net> <20140127103654.GA12714@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Qz2CZ664xQdCRdPu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Jan 27, 2014 at 10:36:54AM +0000, Alexey Dokuchaev wrote:
> On Mon, Jan 27, 2014 at 11:22:31AM +0100, Baptiste Daroussin wrote:
> > This particular port is a bit special as the DESTDIR variable is already
> > defined it but for something totally different, thus I decided to injec=
t a
> > variable named STAGEDIR instead that is why I defined DESTDIRNAME to
> > STAGEDIR in the makefile.
>=20
> OK, fair enough. :) Thanks for replying back.
>=20
> > Your remark is valid is still valid for ports doing
> > --prefix=3D${STAGEDIR}${PREFIX} which is often wrong but not for those =
doing
> > --prefix=3D\$${STAGEDIR}${PREFIX} :)
>=20
> I've just checked StageDir wiki page again; it seems that it already
> contains instructions on how to verify that STAGEDIR does not sneak inside
> the binaries (via bzgrep vs. my own handcrafted strings-based approach).
grep will say the binary matches, but sure it can be improved :)
regards,
Bapt
--Qz2CZ664xQdCRdPu
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (FreeBSD)
iEYEARECAAYFAlLmQKsACgkQ8kTtMUmk6EyD1ACeL8eUHqCEeBhfKTqnwEIqyPjr
nNkAn3L2uGCziR0zPyJYxL8FSGOCNBhX
=bpq3
-----END PGP SIGNATURE-----
--Qz2CZ664xQdCRdPu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140127111907.GE30300>