Date: Sat, 21 May 2011 23:31:26 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215178 - in head: lib/libc/sys sys/kern sys/sys Message-ID: <alpine.BSF.2.00.1105212330270.35370@fledge.watson.org> In-Reply-To: <alpine.BSF.2.00.1105212327440.35370@fledge.watson.org> References: <201011121302.oACD2Qjt009385@svn.freebsd.org> <alpine.BSF.2.00.1105212327440.35370@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 21 May 2011, Robert Watson wrote: > In fact, the code I pointed at in my previous e-mail will probably panic in > that case, since it improperly dereferences the inpcb's socket field without > first testing for NULL. Or, looking more closely, only because the locking is broken, as it does test inp_socket. However, it really shouldn't need to -- we try quite hard never to dereference inp_socket in the firewall code for this reason. Hence, among other things, propagating so_cred down as inp_cred. Robert
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1105212330270.35370>