From owner-p4-projects@FreeBSD.ORG Sat Jan 17 18:18:14 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3E64E16A4D0; Sat, 17 Jan 2004 18:18:14 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 134B316A4CE for ; Sat, 17 Jan 2004 18:18:14 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2F7C43D1D for ; Sat, 17 Jan 2004 18:18:12 -0800 (PST) (envelope-from jmallett@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i0I2IC0B087485 for ; Sat, 17 Jan 2004 18:18:12 -0800 (PST) (envelope-from jmallett@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i0I2ICBR087482 for perforce@freebsd.org; Sat, 17 Jan 2004 18:18:12 -0800 (PST) (envelope-from jmallett@freebsd.org) Date: Sat, 17 Jan 2004 18:18:12 -0800 (PST) Message-Id: <200401180218.i0I2ICBR087482@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jmallett@freebsd.org using -f From: Juli Mallett To: Perforce Change Reviews Subject: PERFORCE change 45513 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jan 2004 02:18:14 -0000 http://perforce.freebsd.org/chv.cgi?CH=45513 Change 45513 by jmallett@jmallett_oingo on 2004/01/17 18:17:28 Trust the hardware to yell about bad PTEs for us. Suggested by: cgd Affected files ... .. //depot/projects/mips/sys/mips/mips/exception.S#11 edit Differences ... ==== //depot/projects/mips/sys/mips/mips/exception.S#11 (text+ko) ==== @@ -189,18 +189,10 @@ */ ld k1, 0(k1) addu k1, k0 - ld k0, 0(k1) /* Even PTE. */ - andi k0, PG_V /* Check validity. */ - bne k0, zero, 2f /* Valid. */ - nop - ld k0, 8(k1) /* Odd PTE. */ - andi k0, PG_V /* Check validity. */ - beq k0, zero, 1f /* Invalid. */ - nop /* - * Valid PTE. Write the pair. + * Write the pair. */ -2: ld k0, 0(k1) /* Even PTE. */ + ld k0, 0(k1) /* Even PTE. */ ld k1, 8(k1) /* Odd PTE. */ /* * Write TLB entry. @@ -212,30 +204,9 @@ nop nop eret -1: j BadPTE - nop - .set at VEND(XTLBMissVector) /* - * Yell about a bogus PTE, at 0(k1). - */ -ENTRY(BadPTE) - .set noat - dmfc0 a3, MIPS_COP_0_BAD_VADDR - move a1, k1 - ld a2, 0(k1) - dla a0, 1f - dla k0, panic - dmtc0 k0, MIPS_COP_0_EXC_PC - eret - .set at -END(BadPTE) - .data -1: .asciiz "Bad PTE at %p (%16lx), badvaddr %lx" - .text - -/* * Handle an interrupt. Return into panic, for now. */ LEAF(Interrupt)