From owner-freebsd-current@FreeBSD.ORG  Thu Jun 19 08:13:28 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4BB8537B401; Thu, 19 Jun 2003 08:13:28 -0700 (PDT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9FAA243FBD; Thu, 19 Jun 2003 08:13:27 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.9/8.12.9) with ESMTP id h5JFDIM7057641;
	Thu, 19 Jun 2003 08:13:22 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200306191513.h5JFDIM7057641@gw.catspoiler.org>
Date: Thu, 19 Jun 2003 08:13:18 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
To: se@FreeBSD.org
In-Reply-To: <20030619093146.GA1489@StefanEsser.FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
cc: chris@Shenton.Org
cc: current@FreeBSD.org
Subject: Re: 5.1-CURRENT hangs on disk i/o? sysctl_old_user() non-sleepable
 locks
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jun 2003 15:13:28 -0000

On 19 Jun, Stefan Eßer wrote:
> On 2003-06-18 20:41 -0700, Don Lewis <truckman@freebsd.org> wrote:
>> On 18 Jun, Chris Shenton wrote:
>> > Don Lewis <truckman@FreeBSD.org> writes:
>> > 
>> >> Try the very untested patch below ...

[ snip ]

>> > Tried it, rebuilt kernel, rebooted, no affect :-(
>> > 
>> > You were correct about apache using it.  Doing a simple
>> > 
>> >   fetch http://pectopah/
>> > 
>> > causes the error, dropping me into ddb if panic enabled. A "tr" shows
>> > the same trace as I submitted yesterday :-(
>> 
>> Wierd ... I just tested the patch with ftpd which also uses sendfile()
>> and didn't get any complaints from DEBUG_VFS_LOCKS.
> 
> Not sure whether the following applies, but I think the patch
> should be commited anyway:

I don't think it applies, but ...

> In PR kern/46652 I reported, that DEBUG_VFS_LOCKS does never
> check the **vpp parameters. A patch is included in the PR and
> it does generate the missing tests.
> 
> I asked for feedback on the hackers mail list (IIRC), but did
> not get any replies. 
> 
> Any objections against me committing the patch now ?
> 
> (A different fix is mentioned in the PR, the patch I suggested
> was the minimal change to the code which made it work, the
> alternative seems cleaner to me ...) Please read PR kern/46652 !

I think the alternative fix should be committed.  That would do the
correct thing if another pointer to a pointer to a vnode argument is
ever added.  I think this is better than adding magic to vpp.


Any idea if this change turns up more problems?